Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-02-05 Thread Kees Cook
On Mon, Jan 4, 2016 at 2:07 PM, Russell King - ARM Linux wrote: > On Mon, Jan 04, 2016 at 12:34:28PM -0800, Kees Cook wrote: >> On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux >> wrote: >> > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: >> >> * Nicolas Pitre [151223

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-02-05 Thread Kees Cook
On Mon, Jan 4, 2016 at 2:07 PM, Russell King - ARM Linux wrote: > On Mon, Jan 04, 2016 at 12:34:28PM -0800, Kees Cook wrote: >> On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux >> wrote: >> > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 12:34:28PM -0800, Kees Cook wrote: > On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux > wrote: > > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: > >> * Nicolas Pitre [151223 13:45]: > >> > We fixed a bunch of similar issues where code was located

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-01-04 Thread Kees Cook
On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux wrote: > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: >> * Nicolas Pitre [151223 13:45]: >> > We fixed a bunch of similar issues where code was located in the .data >> > section for ease of use from assembly code. See

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-01-04 Thread Kees Cook
On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux wrote: > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: >> * Nicolas Pitre [151223 13:45]: >> > We fixed a bunch of similar issues where code was located in the .data >> >

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2016-01-04 Thread Russell King - ARM Linux
On Mon, Jan 04, 2016 at 12:34:28PM -0800, Kees Cook wrote: > On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux > wrote: > > On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: > >> * Nicolas Pitre [151223 13:45]: > >> > We

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: > * Nicolas Pitre [151223 13:45]: > > We fixed a bunch of similar issues where code was located in the .data > > section for ease of use from assembly code. See commit b4e61537 and > > d0776aff for example. > > Thanks hey some

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Nicolas Pitre [151223 13:45]: > On Wed, 23 Dec 2015, Tony Lindgren wrote: > > > Hi, > > > > * Laura Abbott [151223 12:31]: > > > > > > Looks like a case similar to Geert's > > > > > > adr r7, kick_counter > > > wait_dll_lock_timed: > > > ldr r4,

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Nicolas Pitre
On Wed, 23 Dec 2015, Tony Lindgren wrote: > Hi, > > * Laura Abbott [151223 12:31]: > > > > Looks like a case similar to Geert's > > > > adr r7, kick_counter > > wait_dll_lock_timed: > > ldr r4, wait_dll_lock_counter > > add r4, r4, #1 > > str

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
Hi, * Laura Abbott [151223 12:31]: > > Looks like a case similar to Geert's > > adr r7, kick_counter > wait_dll_lock_timed: > ldr r4, wait_dll_lock_counter > add r4, r4, #1 > str r4, [r7, #wait_dll_lock_counter - kick_counter] > ldr

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Laura Abbott
On 12/23/2015 12:15 PM, Russell King - ARM Linux wrote: On Wed, Dec 02, 2015 at 12:27:25PM -0800, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Laura Abbott
On 12/23/2015 11:51 AM, Tony Lindgren wrote: * Kees Cook [151202 12:31]: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean things beyond just

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Russell King - ARM Linux [151223 12:01]: > On Wed, Dec 23, 2015 at 11:51:29AM -0800, Tony Lindgren wrote: > > Also all omap3 boards are now oopsing in Linux next if PM is enabled: > > I'm not sure that's entirely true. My LDP3430 works fine with this > change in place, and that has

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 02, 2015 at 12:27:25PM -0800, Kees Cook wrote: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean things beyond just rodata. To >

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 23, 2015 at 11:51:29AM -0800, Tony Lindgren wrote: > Also all omap3 boards are now oopsing in Linux next if PM is enabled: I'm not sure that's entirely true. My LDP3430 works fine with this change in place, and that has CONFIG_PM=y. See my nightly build/boot results, which includes

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Kees Cook [151202 12:31]: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean things beyond just rodata. To > get ARM closer to this, we

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Nicolas Pitre
On Wed, 23 Dec 2015, Tony Lindgren wrote: > Hi, > > * Laura Abbott [151223 12:31]: > > > > Looks like a case similar to Geert's > > > > adr r7, kick_counter > > wait_dll_lock_timed: > > ldr r4, wait_dll_lock_counter > > add r4, r4, #1 >

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote: > * Nicolas Pitre [151223 13:45]: > > We fixed a bunch of similar issues where code was located in the .data > > section for ease of use from assembly code. See commit b4e61537 and > > d0776aff for

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Nicolas Pitre [151223 13:45]: > On Wed, 23 Dec 2015, Tony Lindgren wrote: > > > Hi, > > > > * Laura Abbott [151223 12:31]: > > > > > > Looks like a case similar to Geert's > > > > > > adr r7, kick_counter > > > wait_dll_lock_timed:

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
Hi, * Laura Abbott [151223 12:31]: > > Looks like a case similar to Geert's > > adr r7, kick_counter > wait_dll_lock_timed: > ldr r4, wait_dll_lock_counter > add r4, r4, #1 > str r4, [r7, #wait_dll_lock_counter - kick_counter]

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 02, 2015 at 12:27:25PM -0800, Kees Cook wrote: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean things beyond just rodata. To >

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Laura Abbott
On 12/23/2015 11:51 AM, Tony Lindgren wrote: * Kees Cook [151202 12:31]: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Kees Cook [151202 12:31]: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean things beyond just rodata. To > get ARM

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Tony Lindgren
* Russell King - ARM Linux [151223 12:01]: > On Wed, Dec 23, 2015 at 11:51:29AM -0800, Tony Lindgren wrote: > > Also all omap3 boards are now oopsing in Linux next if PM is enabled: > > I'm not sure that's entirely true. My LDP3430 works fine with this > change in place,

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Laura Abbott
On 12/23/2015 12:15 PM, Russell King - ARM Linux wrote: On Wed, Dec 02, 2015 at 12:27:25PM -0800, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-23 Thread Russell King - ARM Linux
On Wed, Dec 23, 2015 at 11:51:29AM -0800, Tony Lindgren wrote: > Also all omap3 boards are now oopsing in Linux next if PM is enabled: I'm not sure that's entirely true. My LDP3430 works fine with this change in place, and that has CONFIG_PM=y. See my nightly build/boot results, which includes

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-22 Thread Laura Abbott
On 12/22/2015 02:37 AM, Geert Uytterhoeven wrote: Hi Kees, Russell, On Wed, Dec 2, 2015 at 9:27 PM, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-22 Thread Geert Uytterhoeven
Hi Kees, Russell, On Wed, Dec 2, 2015 at 9:27 PM, Kees Cook wrote: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean things beyond just

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-22 Thread Laura Abbott
On 12/22/2015 02:37 AM, Geert Uytterhoeven wrote: Hi Kees, Russell, On Wed, Dec 2, 2015 at 9:27 PM, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection:

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-22 Thread Geert Uytterhoeven
Hi Kees, Russell, On Wed, Dec 2, 2015 at 9:27 PM, Kees Cook wrote: > The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of > kernel self-protection: > http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 > Additionally, its name has grown to mean

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-02 Thread Laura Abbott
On 12/02/2015 12:27 PM, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean things beyond just rodata. To get ARM closer to this, we

[PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-02 Thread Kees Cook
The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean things beyond just rodata. To get ARM closer to this, we ought to rearrange the names of the

[PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-02 Thread Kees Cook
The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean things beyond just rodata. To get ARM closer to this, we ought to rearrange the names of the

Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA

2015-12-02 Thread Laura Abbott
On 12/02/2015 12:27 PM, Kees Cook wrote: The use of CONFIG_DEBUG_RODATA is generally seen as an essential part of kernel self-protection: http://www.openwall.com/lists/kernel-hardening/2015/11/30/13 Additionally, its name has grown to mean things beyond just rodata. To get ARM closer to this, we