Re: [PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-31 Thread Robert Jarzmik
Joe Perches writes: > On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote: ...zip... > $ git grep -w charger_wakeup > arch/arm/mach-pxa/corgi_pm.c:   .charger_wakeup  = corgi_charger_wakeup, > arch/arm/mach-pxa/sharpsl_pm.c: if >

Re: [PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-31 Thread Robert Jarzmik
Joe Perches writes: > On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote: ...zip... > $ git grep -w charger_wakeup > arch/arm/mach-pxa/corgi_pm.c:   .charger_wakeup  = corgi_charger_wakeup, > arch/arm/mach-pxa/sharpsl_pm.c: if > (sharpsl_pm.machinfo->charger_wakeup() != 0)

Re: [PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-30 Thread Joe Perches
On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote: > The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of > gpio register") from Oct 17, 2011, leads to the following static checker > warning: >   arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() >   warn: double

Re: [PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-30 Thread Joe Perches
On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote: > The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of > gpio register") from Oct 17, 2011, leads to the following static checker > warning: >   arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() >   warn: double

[PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-30 Thread Robert Jarzmik
The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of gpio register") from Oct 17, 2011, leads to the following static checker warning: arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() warn: double left shift '!gpio_get_value(SPITZ_GPIO_KEY_INT) << (1 <<

[PATCH v2] ARM: pxa: fix GPIO double shifts

2016-07-30 Thread Robert Jarzmik
The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of gpio register") from Oct 17, 2011, leads to the following static checker warning: arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup() warn: double left shift '!gpio_get_value(SPITZ_GPIO_KEY_INT) << (1 <<