RE: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Rojewski, Cezary
On 2021-01-20 5:41 PM, Rojewski, Cezary wrote: > > Just checked the history behind this. And must say, I liked Ricardo's > version better. Except for the "= {};" bit which Mark already pointed > out - it should be a separate fix - it's simply more optional Meant to say: optimal.

RE: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Rojewski, Cezary
On 2021-01-20 5:33 PM, Pierre-Louis Bossart wrote: > On 1/20/21 9:49 AM, Łukasz Majczak wrote: >> Hi Pierre, >> >> Is there anything more to do to get the ACK for this patch? > > Adding Cezary and Amadeusz for feedback, I can't pretend having any sort > of knowledge on the Skylake driver

Re: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Pierre-Louis Bossart
On 1/20/21 9:49 AM, Łukasz Majczak wrote: Hi Pierre, Is there anything more to do to get the ACK for this patch? Adding Cezary and Amadeusz for feedback, I can't pretend having any sort of knowledge on the Skylake driver internals and topology usage. Best regards, Lukasz wt., 12 sty

Re: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-20 Thread Łukasz Majczak
Hi Pierre, Is there anything more to do to get the ACK for this patch? Best regards, Lukasz wt., 12 sty 2021 o 12:34 Łukasz Majczak napisał(a): > > Hi, > > This is just a kind reminder. Is there anything more required to > upstream this patch? > > Best regards, > Lukasz > > > czw., 17 gru 2020

Re: [PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2021-01-12 Thread Łukasz Majczak
Hi, This is just a kind reminder. Is there anything more required to upstream this patch? Best regards, Lukasz czw., 17 gru 2020 o 14:06 Lukasz Majczak napisał(a): > > There is no check for the kcontrol against NULL and in some cases > it causes kernel to crash. > > Fixes: 2d744ecf2b984

[PATCH v2] ASoC: Intel: Skylake: Check the kcontrol against NULL

2020-12-17 Thread Lukasz Majczak
There is no check for the kcontrol against NULL and in some cases it causes kernel to crash. Fixes: 2d744ecf2b984 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT") Cc: # 5.4+ Signed-off-by: Lukasz Majczak Reviewed-by: Mateusz Gorski ---