RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI standards get defined and what's there

RE: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-03 Thread Adam Thomson
On 03 May 2018 02:39, Mark Brown wrote: > On Wed, May 02, 2018 at 10:13:55AM +, Adam Thomson wrote: > > On 01 May 2018 21:50, Mark Brown wrote: > > > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > > of a shambles how ACPI standards get defined and what's there

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Mark Brown
On Wed, May 02, 2018 at 10:13:55AM +, Adam Thomson wrote: > On 01 May 2018 21:50, Mark Brown wrote: > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > of a shambles how ACPI standards get defined and what's there is not > > really intended to handle systems like

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Mark Brown
On Wed, May 02, 2018 at 10:13:55AM +, Adam Thomson wrote: > On 01 May 2018 21:50, Mark Brown wrote: > > There's a lot of things that ACPI *should* do but doesn't - it's a bit > > of a shambles how ACPI standards get defined and what's there is not > > really intended to handle systems like

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > > not > > have something

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-02 Thread Adam Thomson
On 01 May 2018 21:50, Mark Brown wrote: > On Mon, Apr 30, 2018 at 07:05:19PM +, Adam Thomson wrote: > > > There is already a means via DT to specify the MCLK for a device using the > > generic clock DT bindings, and this driver already uses that. Should ACPI > > not > > have something

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Mark Brown
On Mon, Apr 30, 2018 at 07:05:19PM +, Adam Thomson wrote: > There is already a means via DT to specify the MCLK for a device using the > generic clock DT bindings, and this driver already uses that. Should ACPI not > have something similar to that which is generic, rather than adding device >

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Mark Brown
On Mon, Apr 30, 2018 at 07:05:19PM +, Adam Thomson wrote: > There is already a means via DT to specify the MCLK for a device using the > generic clock DT bindings, and this driver already uses that. Should ACPI not > have something similar to that which is generic, rather than adding device >

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Pierre-Louis Bossart
On 5/1/18 9:31 AM, Agrawal, Akshu wrote: On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote: On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Pierre-Louis Bossart
On 5/1/18 9:31 AM, Agrawal, Akshu wrote: On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote: On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Agrawal, Akshu
On 5/1/2018 12:35 AM, Adam Thomson wrote: On 30 April 2018 10:23, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers

Re: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Agrawal, Akshu
On 5/1/2018 12:35 AM, Adam Thomson wrote: On 30 April 2018 10:23, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Agrawal, Akshu
On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote: On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-05-01 Thread Agrawal, Akshu
On 4/30/2018 9:54 PM, Pierre-Louis Bossart wrote: On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

RE: [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Adam Thomson
On 30 April 2018 10:23, Akshu Agrawal wrote: > Non-dts based systems can use ACPI DSDT to pass on the mclk > to da7219. > This enables da7219 mclk to be linked to system clock. > Enable/Disable of the mclk is already handled in the codec so > platform drivers don't have to explicitly do handling

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Pierre-Louis Bossart
On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers don't have to explicitly do handling of mclk.

Re: [alsa-devel] [PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Pierre-Louis Bossart
On 4/30/18 4:23 AM, Akshu Agrawal wrote: Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers don't have to explicitly do handling of mclk.

[PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Akshu Agrawal
Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers don't have to explicitly do handling of mclk. Signed-off-by: Akshu Agrawal

[PATCH v2] ASoC: da7219: read fmw property to get mclk for non-dts systems

2018-04-30 Thread Akshu Agrawal
Non-dts based systems can use ACPI DSDT to pass on the mclk to da7219. This enables da7219 mclk to be linked to system clock. Enable/Disable of the mclk is already handled in the codec so platform drivers don't have to explicitly do handling of mclk. Signed-off-by: Akshu Agrawal --- v2: Fixed