Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
On Fri, Feb 9, 2018 at 10:52 PM, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: >> There is some duplicate code in soc-core.c, and the kernel provides >> DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in

Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
On Fri, Feb 9, 2018 at 10:52 PM, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: >> There is some duplicate code in soc-core.c, and the kernel provides >> DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. >> > > You missed my tag. > > Reviewed-by:

Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
On Fri, Feb 9, 2018 at 10:52 PM, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: >> There is some duplicate code in soc-core.c, and the kernel provides >> DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in

Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
On Fri, Feb 9, 2018 at 10:52 PM, Andy Shevchenko wrote: > On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: >> There is some duplicate code in soc-core.c, and the kernel provides >> DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. >> > > You missed my tag. > > Reviewed-by:

Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Andy Shevchenko
On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: > There is some duplicate code in soc-core.c, and the kernel provides > DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. > You missed my tag. Reviewed-by: Andy Shevchenko >

Re: [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Andy Shevchenko
On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng wrote: > There is some duplicate code in soc-core.c, and the kernel provides > DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. > You missed my tag. Reviewed-by: Andy Shevchenko > Signed-off-by: Peng Donglin > --- > v2:

[PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
There is some duplicate code in soc-core.c, and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. Signed-off-by: Peng Donglin --- v2: [addressed comments from Andy] * modify code change description * do not rename m -> s ---

[PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

2018-02-09 Thread Donglin Peng
There is some duplicate code in soc-core.c, and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. Signed-off-by: Peng Donglin --- v2: [addressed comments from Andy] * modify code change description * do not rename m -> s --- sound/soc/soc-core.c | 45