Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-28 Thread Stephan Mueller
Am Mittwoch, 27. August 2014, 21:35:28 schrieb Herbert Xu: Hi Herbert, > On Tue, Aug 26, 2014 at 11:36:54AM +0200, Stephan Mueller wrote: > > The max_addtllen and max_req are defined in drbg_cores[] in crypto/drbg.c > > for each DRBG type. As size_t on a 32 bit system is 32 bit the bit shifts > >

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-27 Thread Stephan Mueller
Am Mittwoch, 27. August 2014, 21:35:28 schrieb Herbert Xu: Hi Herbert, >On Tue, Aug 26, 2014 at 11:36:54AM +0200, Stephan Mueller wrote: >> The max_addtllen and max_req are defined in drbg_cores[] in >> crypto/drbg.c for each DRBG type. As size_t on a 32 bit system is 32 >> bit the bit shifts wou

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-27 Thread Herbert Xu
On Tue, Aug 26, 2014 at 11:36:54AM +0200, Stephan Mueller wrote: > > The max_addtllen and max_req are defined in drbg_cores[] in crypto/drbg.c for > each DRBG type. As size_t on a 32 bit system is 32 bit the bit shifts would > not work either. > > Thus, I am wondering whether the just applied pa

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-26 Thread Stephan Mueller
Am Dienstag, 26. August 2014, 16:58:53 schrieb Herbert Xu: Hi Herbert, > On Tue, Aug 26, 2014 at 10:52:45AM +0200, Stephan Mueller wrote: > > Am Dienstag, 26. August 2014, 16:43:43 schrieb Herbert Xu: > > > > Hi Herbert, > > > > > On Tue, Aug 26, 2014 at 10:29:45AM +0200, Stephan Mueller wrote:

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-26 Thread Herbert Xu
On Tue, Aug 26, 2014 at 10:52:45AM +0200, Stephan Mueller wrote: > Am Dienstag, 26. August 2014, 16:43:43 schrieb Herbert Xu: > > Hi Herbert, > > > On Tue, Aug 26, 2014 at 10:29:45AM +0200, Stephan Mueller wrote: > > > The maximum values for additional input string or generated blocks is > > > la

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-26 Thread Stephan Mueller
Am Dienstag, 26. August 2014, 16:43:43 schrieb Herbert Xu: Hi Herbert, > On Tue, Aug 26, 2014 at 10:29:45AM +0200, Stephan Mueller wrote: > > The maximum values for additional input string or generated blocks is > > larger than 1<<32. To ensure a sensible value on 32 bit systems, return > > SIZE_

Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-26 Thread Herbert Xu
On Tue, Aug 26, 2014 at 10:29:45AM +0200, Stephan Mueller wrote: > The maximum values for additional input string or generated blocks is > larger than 1<<32. To ensure a sensible value on 32 bit systems, return > SIZE_MAX on 32 bit systems. This value is lower than the maximum > allowed values defi

[PATCH v2] DRBG: fix maximum value checks on 32 bit systems

2014-08-26 Thread Stephan Mueller
The maximum values for additional input string or generated blocks is larger than 1<<32. To ensure a sensible value on 32 bit systems, return SIZE_MAX on 32 bit systems. This value is lower than the maximum allowed values defined in SP800-90A. The standard allow lower maximum values, but not larger