Re: [PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df

2014-06-26 Thread Stephan Mueller
Am Donnerstag, 26. Juni 2014, 14:45:42 schrieb Herbert Xu: Hi Herbert, >On Wed, Jun 25, 2014 at 05:08:28PM +0800, Herbert Xu wrote: >> On Mon, Jun 23, 2014 at 09:11:29AM +0200, Stephan Mueller wrote: >> > As reported by a static code analyzer, the code for the ordering of >> > the linked list can

Re: [PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df

2014-06-25 Thread Herbert Xu
On Wed, Jun 25, 2014 at 05:08:28PM +0800, Herbert Xu wrote: > On Mon, Jun 23, 2014 at 09:11:29AM +0200, Stephan Mueller wrote: > > As reported by a static code analyzer, the code for the ordering of > > the linked list can be simplified. > > > > Reported-by: kbuild test robot > > Signed-off-by: S

Re: [PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df

2014-06-25 Thread Herbert Xu
On Mon, Jun 23, 2014 at 09:11:29AM +0200, Stephan Mueller wrote: > As reported by a static code analyzer, the code for the ordering of > the linked list can be simplified. > > Reported-by: kbuild test robot > Signed-off-by: Stephan Mueller > --- > crypto/drbg.c | 10 +- > 1 file changed

[PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df

2014-06-23 Thread Stephan Mueller
This patch superseeds and replaces the initial fix submitted with [1]. After careful analysis of the code, the anticipated NULL pointer deference is caught in drbg_ctr_update which only invokes drbg_ctr_df when addtl is not NULL. This patch is tested with CAVS testing and the test set provided in

[PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df

2014-06-23 Thread Stephan Mueller
As reported by a static code analyzer, the code for the ordering of the linked list can be simplified. Reported-by: kbuild test robot Signed-off-by: Stephan Mueller --- crypto/drbg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/crypto/drbg.c b/crypto/drbg.c ind