Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-28 Thread Baoquan He
On 07/27/15 at 07:45pm, Yinghai Lu wrote: > On Mon, Jul 27, 2015 at 5:52 PM, Baoquan He wrote: > > On 07/22/15 at 04:47pm, Yinghai Lu wrote: > > > > Sorry for late reply. This problem is reported by customers. They usulay > > don't like to make these things public. While for those systems with > >

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Yinghai Lu
On Mon, Jul 27, 2015 at 5:52 PM, Baoquan He wrote: > On 07/22/15 at 04:47pm, Yinghai Lu wrote: > > Sorry for late reply. This problem is reported by customers. They usulay > don't like to make these things public. While for those systems with > good hard iommu support, it could also fail to initia

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Baoquan He
On 07/22/15 at 04:47pm, Yinghai Lu wrote: > On Tue, Jul 21, 2015 at 5:59 PM, Baoquan He wrote: > >> That commit should only be used to workaround some systems that > >> have partial iommu support. > > > > Those big servers mostly has hardware iommu. But they still can > > enable swiotlb suport. Th

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Baoquan He
On 07/27/15 at 11:31am, Yinghai Lu wrote: > >> #else > >> static void __init reserve_crashkernel(void) > > No, you can not move the calling position for reserve_crashkernel_low(). > > old sequence: > > memblock_find_in_range for high > memblock_reserve for high > memblock_find_in_range for l

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Yinghai Lu
On Tue, Jul 21, 2015 at 12:31 AM, Dave Young wrote: >> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c >> index 80f874b..36aeac3 100644 >> --- a/arch/x86/kernel/setup.c >> +++ b/arch/x86/kernel/setup.c >> @@ -513,7 +513,7 @@ static void __init >> memblock_x86_reserve_range_setup_da

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Joerg Roedel
On Tue, Jul 21, 2015 at 09:38:14AM +0200, Ingo Molnar wrote: > Also, why was this syntax introduced in the first place? Why should the user > care?? > > We should only have a single crashkernel option, to enable it - and > everything > else should be figured out by the kernel, automatically. >

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Joerg Roedel
Hi Baoquan, thanks for the fix! On Sun, Jul 19, 2015 at 10:53:20PM +0800, Baoquan He wrote: > People reported that when allocating crashkernel memory using > ",high" and ",low" syntax, there were cases where the reservation > of the "high" portion succeeds, but the reservation of the "low" > port

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-27 Thread Joerg Roedel
On Wed, Jul 22, 2015 at 04:41:00PM -0700, Yinghai Lu wrote: > Do you mean BIOS have that disabled with not exposing DMAR table ? > > kernel for RHEL 6 and RHEL7 have them enabled. > Also opensuse kernel have that enabled too. You still need to pass intel_iommu=on in the kernel command line to ena

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-22 Thread Yinghai Lu
On Tue, Jul 21, 2015 at 5:59 PM, Baoquan He wrote: >> That commit should only be used to workaround some systems that >> have partial iommu support. > > Those big servers mostly has hardware iommu. But they still can > enable swiotlb suport. Then low memory is needed. Do you have whole bootlog? I

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-22 Thread Yinghai Lu
On Tue, Jul 21, 2015 at 9:47 PM, Minfei Huang wrote: > > Since low memory does not need for some machines, how about kexec does > not allocate low memory automatically, if cmdline does not specify the > option ",low". User shall know well, if they specify the cmdline with > option ",high". That w

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-22 Thread Yinghai Lu
On Wed, Jul 22, 2015 at 3:11 AM, Joerg Roedel wrote: > On Tue, Jul 21, 2015 at 12:22:53PM -0700, Yinghai Lu wrote: >> On Tue, Jul 21, 2015 at 1:58 AM, Baoquan He wrote: >> >> > Maybe system which don't need low memory is rare, only for testing? >> >> No, it is not rare. >> >> All recent intel bas

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-22 Thread Joerg Roedel
On Tue, Jul 21, 2015 at 12:22:53PM -0700, Yinghai Lu wrote: > On Tue, Jul 21, 2015 at 1:58 AM, Baoquan He wrote: > > > Maybe system which don't need low memory is rare, only for testing? > > No, it is not rare. > > All recent intel based systems with iommu support does not need low. All Intel-

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Minfei Huang
On 07/21/15 at 12:22pm, Yinghai Lu wrote: > On Tue, Jul 21, 2015 at 1:58 AM, Baoquan He wrote: > > > Maybe system which don't need low memory is rare, only for testing? > > No, it is not rare. > > All recent intel based systems with iommu support does not need low. > > And those systems get pu

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Baoquan He
On 07/21/15 at 09:38am, Ingo Molnar wrote: > > * Dave Young wrote: > > > Hi, Baoquan > > > > The interface was introduced by Yinghai, ccing him. > > Also, why was this syntax introduced in the first place? Why should the user > care?? The user space tool makedumpfile default to use bitmap ar

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Baoquan He
On 07/21/15 at 12:22pm, Yinghai Lu wrote: > On Tue, Jul 21, 2015 at 1:58 AM, Baoquan He wrote: > > > Maybe system which don't need low memory is rare, only for testing? > > No, it is not rare. > > All recent intel based systems with iommu support does not need low. Yeah, you are right. > > A

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Yinghai Lu
On Tue, Jul 21, 2015 at 1:58 AM, Baoquan He wrote: > Maybe system which don't need low memory is rare, only for testing? No, it is not rare. All recent intel based systems with iommu support does not need low. And those systems get punished by following patch: | commit 94fb9334182284e8e7e4bcb

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Baoquan He
On 07/21/15 at 04:23pm, Dave Young wrote: > > I think so. the reason why ,low is introduced is swiotlb or pci device > > need low memory when crashkernel is reserved above 4G. Low memory is > > necessary when ,high is specified unless user can make sure their > > machines don't need low memory and

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Dave Young
On 07/21/15 at 03:50pm, Baoquan He wrote: > Hi Dave, > > On 07/21/15 at 03:31pm, Dave Young wrote: > > Hi, Baoquan > > > > The interface was introduced by Yinghai, ccing him. > > > > On 07/19/15 at 10:53pm, Baoquan He wrote: > > > People reported that when allocating crashkernel memory using > >

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Dave Young
On 07/21/15 at 09:38am, Ingo Molnar wrote: > > * Dave Young wrote: > > > Hi, Baoquan > > > > The interface was introduced by Yinghai, ccing him. > > Also, why was this syntax introduced in the first place? Why should the user > care?? The history is like below, I might miss something, Yingha

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Baoquan He
Hi Dave, On 07/21/15 at 03:31pm, Dave Young wrote: > Hi, Baoquan > > The interface was introduced by Yinghai, ccing him. > > On 07/19/15 at 10:53pm, Baoquan He wrote: > > People reported that when allocating crashkernel memory using > > ",high" and ",low" syntax, there were cases where the reser

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Ingo Molnar
* Dave Young wrote: > Hi, Baoquan > > The interface was introduced by Yinghai, ccing him. Also, why was this syntax introduced in the first place? Why should the user care?? We should only have a single crashkernel option, to enable it - and everything else should be figured out by the kern

Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-21 Thread Dave Young
Hi, Baoquan The interface was introduced by Yinghai, ccing him. On 07/19/15 at 10:53pm, Baoquan He wrote: > People reported that when allocating crashkernel memory using > ",high" and ",low" syntax, there were cases where the reservation > of the "high" portion succeeds, but the reservation of th

[PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

2015-07-19 Thread Baoquan He
People reported that when allocating crashkernel memory using ",high" and ",low" syntax, there were cases where the reservation of the "high" portion succeeds, but the reservation of the "low" portion fails. Then kexec can load kdump kernel successfully, but the boot of kdump kernel fails as there'