Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-26 Thread Mark Rutland
On Wed, Oct 21, 2015 at 03:41:37PM -0500, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC: ijc+devicet...@hellion.org.uk > CC: ga...@codeaurora.org > CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-26 Thread Mark Rutland
On Wed, Oct 21, 2015 at 03:41:37PM -0500, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC: ijc+devicet...@hellion.org.uk > CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Hanjun Guo
On 2015/10/24 1:58, Brijesh Singh wrote: >> So I checked the x86 code: the driver is always loaded as soon as the >> hardware is there (looking at PCI device IDs from the on-chip >> northbridge, for instance). The trick here is to have the Kconfig option >> defaulting to "=n", so a kernel builder

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Brijesh Singh
> So I checked the x86 code: the driver is always loaded as soon as the > hardware is there (looking at PCI device IDs from the on-chip > northbridge, for instance). The trick here is to have the Kconfig option > defaulting to "=n", so a kernel builder would have to explicitly enable > this.

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Stephen Boyd
Drive by nitpicks On 10/21, Brijesh Singh wrote: > diff --git a/drivers/edac/cortex_arm64_edac.c > b/drivers/edac/cortex_arm64_edac.c > new file mode 100644 > index 000..c37bb94 > --- /dev/null > +++ b/drivers/edac/cortex_arm64_edac.c > + > +#define L1_CACHE 0 > +#define

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Andre Przywara
On 23/10/15 02:41, Hanjun Guo wrote: > Hi Brijesh, > > On 2015/10/22 22:46, Brijesh Singh wrote: >> Hi Andre, >> >> On 10/21/2015 06:52 PM, Andre Przywara wrote: >>> On 21/10/15 21:41, Brijesh Singh wrote: Add support for Cortex A57 and A53 EDAC driver. >>> Hi Brijesh, >>> >>> thanks for the

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Brijesh Singh
> So I checked the x86 code: the driver is always loaded as soon as the > hardware is there (looking at PCI device IDs from the on-chip > northbridge, for instance). The trick here is to have the Kconfig option > defaulting to "=n", so a kernel builder would have to explicitly enable > this.

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Andre Przywara
On 23/10/15 02:41, Hanjun Guo wrote: > Hi Brijesh, > > On 2015/10/22 22:46, Brijesh Singh wrote: >> Hi Andre, >> >> On 10/21/2015 06:52 PM, Andre Przywara wrote: >>> On 21/10/15 21:41, Brijesh Singh wrote: Add support for Cortex A57 and A53 EDAC driver. >>> Hi Brijesh, >>> >>> thanks for the

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Stephen Boyd
Drive by nitpicks On 10/21, Brijesh Singh wrote: > diff --git a/drivers/edac/cortex_arm64_edac.c > b/drivers/edac/cortex_arm64_edac.c > new file mode 100644 > index 000..c37bb94 > --- /dev/null > +++ b/drivers/edac/cortex_arm64_edac.c > + > +#define L1_CACHE 0 > +#define

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-23 Thread Hanjun Guo
On 2015/10/24 1:58, Brijesh Singh wrote: >> So I checked the x86 code: the driver is always loaded as soon as the >> hardware is there (looking at PCI device IDs from the on-chip >> northbridge, for instance). The trick here is to have the Kconfig option >> defaulting to "=n", so a kernel builder

RE: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Singh, Brijeshkumar
...@vger.kernel.org Subject: Re: [PATCH v2] EDAC: Add ARM64 EDAC >>> +++ b/drivers/edac/cortex_arm64_edac.c >>> @@ -0,0 +1,457 @@ >>> +/* >>> + * Cortex ARM64 EDAC >>> + * >>> + * Copyright (c) 2015, Advanced Micro Devices >>> + *

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Stepan Moskovchenko
>>> +++ b/drivers/edac/cortex_arm64_edac.c >>> @@ -0,0 +1,457 @@ >>> +/* >>> + * Cortex ARM64 EDAC >>> + * >>> + * Copyright (c) 2015, Advanced Micro Devices >>> + * Author: Brijesh Singh >>> + * Hi Brijesh, Your ARM64 EDAC driver seems rather similar to the existing driver that is linked

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Hanjun Guo
Hi Brijesh, On 2015/10/22 22:46, Brijesh Singh wrote: > Hi Andre, > > On 10/21/2015 06:52 PM, Andre Przywara wrote: >> On 21/10/15 21:41, Brijesh Singh wrote: >>> Add support for Cortex A57 and A53 EDAC driver. >> Hi Brijesh, >> >> thanks for the quick update! Some comments below. >> >>>

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Mauro, On 10/21/2015 04:25 PM, Mauro Carvalho Chehab wrote: > Em Wed, 21 Oct 2015 15:41:37 -0500 > Brijesh Singh escreveu: > >> Add support for Cortex A57 and A53 EDAC driver. >> >> Signed-off-by: Brijesh Singh >> CC: robh...@kernel.org >> CC: pawel.m...@arm.com >> CC: mark.rutl...@arm.com

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Andre, On 10/21/2015 06:52 PM, Andre Przywara wrote: > On 21/10/15 21:41, Brijesh Singh wrote: >> Add support for Cortex A57 and A53 EDAC driver. > > Hi Brijesh, > > thanks for the quick update! Some comments below. > >> >> Signed-off-by: Brijesh Singh >> CC: robh...@kernel.org >> CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Mauro, On 10/21/2015 04:25 PM, Mauro Carvalho Chehab wrote: > Em Wed, 21 Oct 2015 15:41:37 -0500 > Brijesh Singh escreveu: > >> Add support for Cortex A57 and A53 EDAC driver. >> >> Signed-off-by: Brijesh Singh >> CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Brijesh Singh
Hi Andre, On 10/21/2015 06:52 PM, Andre Przywara wrote: > On 21/10/15 21:41, Brijesh Singh wrote: >> Add support for Cortex A57 and A53 EDAC driver. > > Hi Brijesh, > > thanks for the quick update! Some comments below. > >> >> Signed-off-by: Brijesh Singh >> CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Stepan Moskovchenko
>>> +++ b/drivers/edac/cortex_arm64_edac.c >>> @@ -0,0 +1,457 @@ >>> +/* >>> + * Cortex ARM64 EDAC >>> + * >>> + * Copyright (c) 2015, Advanced Micro Devices >>> + * Author: Brijesh Singh >>> + * Hi Brijesh, Your ARM64 EDAC driver seems rather similar to the

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Hanjun Guo
Hi Brijesh, On 2015/10/22 22:46, Brijesh Singh wrote: > Hi Andre, > > On 10/21/2015 06:52 PM, Andre Przywara wrote: >> On 21/10/15 21:41, Brijesh Singh wrote: >>> Add support for Cortex A57 and A53 EDAC driver. >> Hi Brijesh, >> >> thanks for the quick update! Some comments below. >> >>>

RE: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-22 Thread Singh, Brijeshkumar
...@vger.kernel.org Subject: Re: [PATCH v2] EDAC: Add ARM64 EDAC >>> +++ b/drivers/edac/cortex_arm64_edac.c >>> @@ -0,0 +1,457 @@ >>> +/* >>> + * Cortex ARM64 EDAC >>> + * >>> + * Copyright (c) 2015, Advanced Micro Devices >>> + * A

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Andre Przywara
On 21/10/15 21:41, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. Hi Brijesh, thanks for the quick update! Some comments below. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Oct 2015 15:41:37 -0500 Brijesh Singh escreveu: > Add support for Cortex A57 and A53 EDAC driver. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC: ijc+devicet...@hellion.org.uk > CC: ga...@codeaurora.org > CC:

[PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC: mche...@osg.samsung.com CC:

[PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Brijesh Singh
Add support for Cortex A57 and A53 EDAC driver. Signed-off-by: Brijesh Singh CC: robh...@kernel.org CC: pawel.m...@arm.com CC: mark.rutl...@arm.com CC: ijc+devicet...@hellion.org.uk CC: ga...@codeaurora.org CC: dougthomp...@xmission.com CC: b...@alien8.de CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Oct 2015 15:41:37 -0500 Brijesh Singh escreveu: > Add support for Cortex A57 and A53 EDAC driver. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com > CC:

Re: [PATCH v2] EDAC: Add ARM64 EDAC

2015-10-21 Thread Andre Przywara
On 21/10/15 21:41, Brijesh Singh wrote: > Add support for Cortex A57 and A53 EDAC driver. Hi Brijesh, thanks for the quick update! Some comments below. > > Signed-off-by: Brijesh Singh > CC: robh...@kernel.org > CC: pawel.m...@arm.com > CC: mark.rutl...@arm.com >