Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-24 Thread Rafael J. Wysocki
On Friday 12 of October 2012 20:31:38 Tang Chen wrote: > "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array > container_device_ids[], so use it, but not the hard coding style. > > Also, introduce a new api is_container_device() to determine if a > device is a container device. > > Signed

Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-23 Thread Bjorn Helgaas
On Fri, Oct 12, 2012 at 6:31 AM, Tang Chen wrote: > "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array > container_device_ids[], so use it, but not the hard coding style. > > Also, introduce a new api is_container_device() to determine if a > device is a container device. > > Signed-off-b

Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-23 Thread Tang Chen
Hi, Would somebody give some comments ? Thanks. :) On 10/12/2012 08:31 PM, Tang Chen wrote: "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array container_device_ids[], so use it, but not the hard coding style. Also, introduce a new api is_container_device() to determine if a device is

Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-16 Thread Tang Chen
Hi, Would anyone help to review this patch, and give some comments, please ? Thanks. :) On 10/12/2012 08:31 PM, Tang Chen wrote: "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array container_device_ids[], so use it, but not the hard coding style. Also, introduce a new api is_container

[PATCH v2] Fix a hard coding style when determining if a device is a container.

2012-10-12 Thread Tang Chen
"ACPI0004","PNP0A05" and "PNP0A06" are all defined in array container_device_ids[], so use it, but not the hard coding style. Also, introduce a new api is_container_device() to determine if a device is a container device. Signed-off-by: Tang Chen Signed-off-by: Yasuaki Ishimatsu --- drivers/ac