Re: [PATCH v2] HID: debug: fix the ring buffer implementation

2019-01-29 Thread Vladis Dronov
> > I still think that > > > > __set_current_state(TASK_RUNNING); > > > > will look a bit better, but this is really minor. > > Would you mind sending a v3 with this change? I'll apply it ASAP. Done, please, see inbox. Best regards, Vladis Dronov | Red Hat, Inc. | Product Sec

Re: [PATCH v2] HID: debug: fix the ring buffer implementation

2019-01-29 Thread Benjamin Tissoires
Vlad, On Mon, Jan 28, 2019 at 12:18 PM Oleg Nesterov wrote: > > On 01/28, Benjamin Tissoires wrote: > > > > Oleg, can you provide some feedback before I push this? > > Looks good to me, feel free to add > > Reviewed-by: Oleg Nesterov > > > > + set_current_state(TASK_RUNNING); > > I

Re: [PATCH v2] HID: debug: fix the ring buffer implementation

2019-01-28 Thread Oleg Nesterov
On 01/28, Benjamin Tissoires wrote: > > Oleg, can you provide some feedback before I push this? Looks good to me, feel free to add Reviewed-by: Oleg Nesterov > > + set_current_state(TASK_RUNNING); I still think that __set_current_state(TASK_RUNNING); will lo

Re: [PATCH v2] HID: debug: fix the ring buffer implementation

2019-01-28 Thread Benjamin Tissoires
On Sat, Jan 26, 2019 at 6:07 PM Vladis Dronov wrote: > > Ring buffer implementation in hid_debug_event() and hid_debug_events_read() > is strange allowing lost or corrupted data. After commit 717adfdaf147 > ("HID: debug: check length before copy_to_user()") it is possible to enter > an infinite lo

[PATCH v2] HID: debug: fix the ring buffer implementation

2019-01-26 Thread Vladis Dronov
Ring buffer implementation in hid_debug_event() and hid_debug_events_read() is strange allowing lost or corrupted data. After commit 717adfdaf147 ("HID: debug: check length before copy_to_user()") it is possible to enter an infinite loop in hid_debug_events_read() by providing 0 as count, this lock