Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Jack Morgenstein
On Monday 25 February 2013 19:23, Roland Dreier wrote: > On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > > I'm finally noticing that this is in the build_mlx_header() function, > > which is pretty much a slow path. Certainly another compare isn't > > going to change performance given all

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > I'm finally noticing that this is in the build_mlx_header() function, > which is pretty much a slow path. Certainly another compare isn't > going to change performance given all the other stuff we do there. > > Let me look at the patches tha

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Sun, Feb 24, 2013 at 4:34 AM, Jack Morgenstein wrote: > However, this approach does add the line below to processing for an IB port > (ETH/RoCE port stays same, more or less). > Processing time is therefore increased (at least on the IB side) relative to > just living with the warning. > > Ro

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-24 Thread Jack Morgenstein
On Thursday 21 February 2013 11:02, Paul Bolle wrote: > diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c > index 19e0637..512fde3 100644 > --- a/drivers/infiniband/hw/mlx4/qp.c > +++ b/drivers/infiniband/hw/mlx4/qp.c > @@ -1778,8 +1778,8 @@ static int build_mlx_header

[PATCH v2] IB/mlx4: silence GCC warning

2013-02-21 Thread Paul Bolle
Building qp.o (part of the "Mellanox ConnectX HCA support" driver) triggers this GCC warning: drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’: drivers/infiniband/hw/mlx4/qp.c:1862:30: warning: ‘vlan’ may be used uninitialized in this function [-Wmaybe-uninitialized] dr