Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-22 Thread Doug Ledford
On Mon, 2017-09-18 at 12:28 +0100, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But delay_drop_debugfs_cleanup()

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-22 Thread Doug Ledford
On Mon, 2017-09-18 at 12:28 +0100, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and since

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-18 Thread Leon Romanovsky
On Mon, Sep 18, 2017 at 12:28:48PM +0100, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But

Re: [PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-18 Thread Leon Romanovsky
On Mon, Sep 18, 2017 at 12:28:48PM +0100, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > If delay_drop_debugfs_init() fails in any of the operations to create > debugfs, it is calling delay_drop_debugfs_cleanup() as part of its > cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and

[PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-18 Thread Sudip Mukherjee
From: Sudip Mukherjee If delay_drop_debugfs_init() fails in any of the operations to create debugfs, it is calling delay_drop_debugfs_cleanup() as part of its cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and since we have not yet pointed 'dbg' to the

[PATCH v2] IB/mlx5: fix debugfs cleanup

2017-09-18 Thread Sudip Mukherjee
From: Sudip Mukherjee If delay_drop_debugfs_init() fails in any of the operations to create debugfs, it is calling delay_drop_debugfs_cleanup() as part of its cleanup. But delay_drop_debugfs_cleanup() checks for 'dbg' and since we have not yet pointed 'dbg' to the debugfs we need to cleanup, the