Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-27 Thread Dmitry Torokhov
On Tue, Nov 26, 2013 at 05:20:13PM -0800, Guenter Roeck wrote: > On 11/26/2013 10:58 AM, Dmitry Torokhov wrote: > >Hi Guenter, > > > >On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > >>Simplify the code and create mandatory 'name' attribute by using > >>new hwmon API. > > > >So this

Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Guenter Roeck
On 11/26/2013 10:58 AM, Dmitry Torokhov wrote: Hi Guenter, On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: Simplify the code and create mandatory 'name' attribute by using new hwmon API. So this moves hwmon attributes from the parent i2c device to the hwmon device, right? Would

Re: [lm-sensors] [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Jean Delvare
Hi Dmitry, On Tue, 26 Nov 2013 10:58:46 -0800, Dmitry Torokhov wrote: > On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > > Simplify the code and create mandatory 'name' attribute by using > > new hwmon API. > > So this moves hwmon attributes from the parent i2c device to the hwmon

Re: [PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-26 Thread Dmitry Torokhov
Hi Guenter, On Mon, Nov 25, 2013 at 08:39:04PM -0800, Guenter Roeck wrote: > Simplify the code and create mandatory 'name' attribute by using > new hwmon API. So this moves hwmon attributes from the parent i2c device to the hwmon device, right? Would not that break userspace which expects to find

[PATCH v2] Input: ads7846: Convert to hwmon_device_register_with_groups

2013-11-25 Thread Guenter Roeck
Simplify the code and create mandatory 'name' attribute by using new hwmon API. Also use is_visible to determine visible attributes instead of creating several different attribute groups. Signed-off-by: Guenter Roeck --- v2: Use hwmon_device_register_with_groups instead of devm_hwmon_device_