Re: [PATCH v2] Input: applespi - register touchpad device synchronously in probe

2019-07-30 Thread Andy Shevchenko
On Mon, Jul 29, 2019 at 11:56:48PM -0700, Life is hard, and then you die wrote: > On Mon, Jul 29, 2019 at 03:22:03PM +0200, Dmitry Torokhov wrote: > > On Sun, Jul 21, 2019 at 12:05:23AM -0700, Ronald Tschalär wrote: > > Question: is it possible to read command response synchronously as well? > >

Re: [PATCH v2] Input: applespi - register touchpad device synchronously in probe

2019-07-30 Thread Life is hard, and then you die
Hi Dmitry, On Mon, Jul 29, 2019 at 03:22:03PM +0200, Dmitry Torokhov wrote: > Hi Ronald, > > On Sun, Jul 21, 2019 at 12:05:23AM -0700, Ronald Tschalär wrote: > > This allows errors during registration to properly fail the probe > > function. > > > > Doing this requires waiting for a

Re: [PATCH v2] Input: applespi - register touchpad device synchronously in probe

2019-07-29 Thread Dmitry Torokhov
Hi Ronald, On Sun, Jul 21, 2019 at 12:05:23AM -0700, Ronald Tschalär wrote: > This allows errors during registration to properly fail the probe > function. > > Doing this requires waiting for a response from the device inside the > probe function. While this generally takes about 15ms, in case

[PATCH v2] Input: applespi - register touchpad device synchronously in probe

2019-07-21 Thread Ronald Tschalär
This allows errors during registration to properly fail the probe function. Doing this requires waiting for a response from the device inside the probe function. While this generally takes about 15ms, in case of errors it could be arbitrarily long, and hence a 3 second timeout is used. This also