Hi,
On 9/17/20 7:22 AM, Bharathi, Divya wrote:
+
+/**
+ * exit_enum_attributes() - Clear all attribute data
+ * @kset: The kset to free
+ *
+ * Clears all data allocated for this group of attributes **/ void
+exit_enum_attributes(struct kset *kset) {
+ struct kobject *pos, *next;
+
+
Hi,
On 9/15/20 6:28 PM, Bharathi, Divya wrote:
+/* kept variable names same as in sysfs file name for sysfs_show
+macro
definition */
+struct enumeration_data {
+ char display_name_language_code[MAX_BUFF];
+ char attribute_name[MAX_BUFF];
+ char display_name[MAX_BUFF];
+
Hi,
On 9/14/20 7:12 PM, Limonciello, Mario wrote:
+static int call_biosattributes_interface(struct wmi_device *wdev, char
*in_args, size_t size,
+ int method_id)
+{
+ struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
+ struct acpi_bu
> >
> > >
> > > > +
> > > > +/* kept variable names same as in sysfs file name for sysfs_show
> > > > +macro
> > > definition */
> > > > +struct enumeration_data {
> > > > + char display_name_language_code[MAX_BUFF];
> > > > + char attribute_name[MAX_BUFF];
> > > > + char displ
> >
> > On 9/4/20 4:28 PM, Divya Bharathi wrote:
> > > diff --git a/drivers/platform/x86/dell-wmi-biosattr-interface.c
> > b/drivers/platform/x86/dell-wmi-biosattr-interface.c
> > > new file mode 100644
> > > index ..dda38d448fec
> > > --- /dev/null
> > > +++ b/drivers/platform/x86/del
Hi,
Like last-time I will split this review in 2,
this second email focusses on the code.
Note I'm still mainly focusing on the overall
structure and how you handle locking here.
Further reviews (of newer versions) will look
at the per function code in more detail.
On 9/4/20 4:28 PM, Divya Bha
>
> On 9/4/20 4:28 PM, Divya Bharathi wrote:
> > diff --git a/drivers/platform/x86/dell-wmi-biosattr-interface.c
> b/drivers/platform/x86/dell-wmi-biosattr-interface.c
> > new file mode 100644
> > index ..dda38d448fec
> > --- /dev/null
> > +++ b/drivers/platform/x86/dell-wmi-biosattr-i
Hi,
Like last-time I will split this review in 2,
this first email will focus on the sysfs API/ABI part only.
On 9/4/20 4:28 PM, Divya Bharathi wrote:
The Dell WMI Systems Management Driver provides a sysfs
interface for systems management to enable BIOS configuration
capability on certain Dell
On Fri, Sep 04, 2020 at 07:58:46PM +0530, Divya Bharathi wrote:
> The Dell WMI Systems Management Driver provides a sysfs
> interface for systems management to enable BIOS configuration
> capability on certain Dell Systems.
>
> This driver allows user to configure Dell systems with a
> uniform com
The Dell WMI Systems Management Driver provides a sysfs
interface for systems management to enable BIOS configuration
capability on certain Dell Systems.
This driver allows user to configure Dell systems with a
uniform common interface. To facilitate this, the patch
introduces a generic way for dr
10 matches
Mail list logo
