Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-20 Thread Wanpeng Li
2017-07-20 15:57 GMT+08:00 Radim Krčmář : > 2017-07-19 16:40-0700, Wanpeng Li: >> From: Wanpeng Li >> >> This can be reproduced by EPT=1, unrestricted_guest=N, >> emulate_invalid_state=Y >> or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-20 Thread Wanpeng Li
2017-07-20 15:57 GMT+08:00 Radim Krčmář : > 2017-07-19 16:40-0700, Wanpeng Li: >> From: Wanpeng Li >> >> This can be reproduced by EPT=1, unrestricted_guest=N, >> emulate_invalid_state=Y >> or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it >> tries >> to emulate invalid

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-20 Thread Radim Krčmář
2017-07-19 16:40-0700, Wanpeng Li: > From: Wanpeng Li > > This can be reproduced by EPT=1, unrestricted_guest=N, > emulate_invalid_state=Y > or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it > tries > to emulate invalid guest state task-switch:

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-20 Thread Radim Krčmář
2017-07-19 16:40-0700, Wanpeng Li: > From: Wanpeng Li > > This can be reproduced by EPT=1, unrestricted_guest=N, > emulate_invalid_state=Y > or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it > tries > to emulate invalid guest state task-switch: > > kvm_exit: reason

[PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
From: Wanpeng Li This can be reproduced by EPT=1, unrestricted_guest=N, emulate_invalid_state=Y or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it tries to emulate invalid guest state task-switch: kvm_exit: reason TASK_SWITCH rip 0x0 info 4058

[PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
From: Wanpeng Li This can be reproduced by EPT=1, unrestricted_guest=N, emulate_invalid_state=Y or EPT=0, the trace of kvm-unit-tests/taskswitch2.flat is like below, it tries to emulate invalid guest state task-switch: kvm_exit: reason TASK_SWITCH rip 0x0 info 4058 0 kvm_emulate_insn:

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 7:06 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 6:53 GMT+08:00 Nadav Amit : >>> Wanpeng Li wrote: >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 6:53 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : Radim Krčmář wrote: > 2017-07-19 08:14-0700,

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 7:06 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 6:53 GMT+08:00 Nadav Amit : >>> Wanpeng Li wrote: >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 6:53 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : Radim Krčmář wrote: > 2017-07-19 08:14-0700, Nadav Amit: >> Radim Krčmář wrote: >>> @@ -2363,6 +2368,8 @@ static unsigned long

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 6:53 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 0:25 GMT+08:00 Nadav Amit : >>> Radim Krčmář wrote: >>> 2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 6:53 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 0:25 GMT+08:00 Nadav Amit : >>> Radim Krčmář wrote: >>> 2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář wrote: >> @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct >> kvm_vcpu *vcpu)

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 0:25 GMT+08:00 Nadav Amit : >> Radim Krčmář wrote: >> >>> 2017-07-19 08:14-0700, Nadav Amit: Radim Krčmář wrote: > @@ -2363,6 +2368,8 @@ static unsigned long

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 0:25 GMT+08:00 Nadav Amit : >> Radim Krčmář wrote: >> >>> 2017-07-19 08:14-0700, Nadav Amit: Radim Krčmář wrote: > @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu > *vcpu) > > static void vmx_set_rflags(struct

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu *vcpu) static

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu *vcpu) static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Radim Krčmář wrote: > 2017-07-19 08:14-0700, Nadav Amit: >> Radim Krčmář wrote: >>> @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu >>> *vcpu) >>> >>> static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags) >>>

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Radim Krčmář wrote: > 2017-07-19 08:14-0700, Nadav Amit: >> Radim Krčmář wrote: >>> @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu >>> *vcpu) >>> >>> static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags) >>> { >>> + unsigned long old_rflags =

[PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Radim Krčmář
2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář wrote: > > @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu > > *vcpu) > > > > static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags) > > { > > + unsigned long old_rflags =

[PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Radim Krčmář
2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář wrote: > > @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu > > *vcpu) > > > > static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags) > > { > > + unsigned long old_rflags = to_vmx(vcpu)->rflags; > >