Re: [PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-08-30 Thread Paolo Bonzini
On 27/08/20 22:40, Sean Christopherson wrote: > Paolo pushed an alternative solution for 5.8, commit 5e105c88ab485 ("KVM: > nVMX: check for invalid hdr.vmx.flags"). His argument was that there was > no point in adding proper padding since we already broke the ABI, i.e. > damage done. > > So rathe

Re: [PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-08-30 Thread Paolo Bonzini
On 27/08/20 22:40, Sean Christopherson wrote: > Paolo pushed an alternative solution for 5.8, commit 5e105c88ab485 ("KVM: > nVMX: check for invalid hdr.vmx.flags"). His argument was that there was > no point in adding proper padding since we already broke the ABI, i.e. > damage done. > > So rathe

Re: [PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-08-27 Thread Sean Christopherson
On Thu, Aug 27, 2020 at 11:25:25AM -0700, Jim Mattson wrote: > On Mon, Jul 13, 2020 at 11:23 AM Jim Mattson wrote: > > > > On Mon, Jul 13, 2020 at 9:22 AM Vitaly Kuznetsov > > wrote: > > > > > > Before commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer > > > migration") struct kvm_vmx_nes

Re: [PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-08-27 Thread Jim Mattson
On Mon, Jul 13, 2020 at 11:23 AM Jim Mattson wrote: > > On Mon, Jul 13, 2020 at 9:22 AM Vitaly Kuznetsov wrote: > > > > Before commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer > > migration") struct kvm_vmx_nested_state_hdr looked like: > > > > struct kvm_vmx_nested_state_hdr { > >

Re: [PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-07-13 Thread Jim Mattson
On Mon, Jul 13, 2020 at 9:22 AM Vitaly Kuznetsov wrote: > > Before commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer > migration") struct kvm_vmx_nested_state_hdr looked like: > > struct kvm_vmx_nested_state_hdr { > __u64 vmxon_pa; > __u64 vmcs12_pa; > struct { >

[PATCH v2] KVM: nVMX: fix the layout of struct kvm_vmx_nested_state_hdr

2020-07-13 Thread Vitaly Kuznetsov
Before commit 850448f35aaf ("KVM: nVMX: Fix VMX preemption timer migration") struct kvm_vmx_nested_state_hdr looked like: struct kvm_vmx_nested_state_hdr { __u64 vmxon_pa; __u64 vmcs12_pa; struct { __u16 flags; } smm; } The ABI got broken by the abo