Re: [PATCH v2] MIPS: Add basic support for ptrace single step

2021-02-18 Thread Thomas Bogendoerfer
On Tue, Feb 16, 2021 at 02:55:36PM +0100, Maciej W. Rozycki wrote: > On Fri, 12 Feb 2021, Thomas Bogendoerfer wrote: > > > > IMHO ptrace single step is for CPUs supporting single stepping and not > > > for emulating it in the kernel. > > > > I've checked other arch how they implement single step,

Re: [PATCH v2] MIPS: Add basic support for ptrace single step

2021-02-16 Thread Maciej W. Rozycki
On Fri, 12 Feb 2021, Thomas Bogendoerfer wrote: > > IMHO ptrace single step is for CPUs supporting single stepping and not > > for emulating it in the kernel. > > I've checked other arch how they implement single step, and looks like > I'm wrong. So I'm ok with applying your patch. Can you resend

Re: [PATCH v2] MIPS: Add basic support for ptrace single step

2021-02-12 Thread Thomas Bogendoerfer
On Thu, Feb 11, 2021 at 11:29:05AM +0100, Thomas Bogendoerfer wrote: > IMHO ptrace single step is for CPUs supporting single stepping and not > for emulating it in the kernel. I've checked other arch how they implement single step, and looks like I'm wrong. So I'm ok with applying your patch. Can

Re: [PATCH v2] MIPS: Add basic support for ptrace single step

2021-02-11 Thread Thomas Bogendoerfer
On Wed, Feb 10, 2021 at 02:52:41PM +0800, Tiezhu Yang wrote: > In the current code, arch_has_single_step() is not defined on MIPS, > that means MIPS does not support instruction single-step for user mode. > > Delve is a debugger for the Go programming language, the ptrace syscall > PtraceSingleSte