Re: [PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-26 Thread Timo Kokkonen
On 02.25 2013 23:17:27, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically d

Re: [PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-26 Thread Sakari Ailus
Hi Dmitry, On Mon, Feb 25, 2013 at 11:17:27PM -0800, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_drive

Re: [PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-25 Thread Guennadi Liakhovetski
On Mon, 25 Feb 2013, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() which specifically dis

[PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-25 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Similarly probe(