Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-30 Thread Sinan Kaya
On 12/28/2015 5:29 PM, Bjorn Helgaas wrote: > Hi Sinan, > > Sorry for the delay in responding; I was on vacation when you sent > this, and I missed it when I returned. > > On Mon, Dec 14, 2015 at 01:22:39PM -0500, Sinan Kaya wrote: >> On 12/11/2015 6:30 PM, Sinan Kaya wrote: I think the

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-30 Thread Sinan Kaya
On 12/28/2015 5:29 PM, Bjorn Helgaas wrote: > Hi Sinan, > > Sorry for the delay in responding; I was on vacation when you sent > this, and I missed it when I returned. > > On Mon, Dec 14, 2015 at 01:22:39PM -0500, Sinan Kaya wrote: >> On 12/11/2015 6:30 PM, Sinan Kaya wrote: I think the

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-28 Thread Bjorn Helgaas
Hi Sinan, Sorry for the delay in responding; I was on vacation when you sent this, and I missed it when I returned. On Mon, Dec 14, 2015 at 01:22:39PM -0500, Sinan Kaya wrote: > On 12/11/2015 6:30 PM, Sinan Kaya wrote: > >> I think the best way to fix all the cases would be to do something in >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-28 Thread Bjorn Helgaas
Hi Sinan, Sorry for the delay in responding; I was on vacation when you sent this, and I missed it when I returned. On Mon, Dec 14, 2015 at 01:22:39PM -0500, Sinan Kaya wrote: > On 12/11/2015 6:30 PM, Sinan Kaya wrote: > >> I think the best way to fix all the cases would be to do something in >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-14 Thread Sinan Kaya
On 12/11/2015 6:30 PM, Sinan Kaya wrote: >> I think the best way to fix all the cases would be to do something in >> > in pci_configure_device(). Then we could drop the AER bus walk in >> > set_downstream_devices_error_reporting(). A bus walk like that is >> > always an issue for hotplug. >> >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-14 Thread Sinan Kaya
On 12/11/2015 6:30 PM, Sinan Kaya wrote: >> I think the best way to fix all the cases would be to do something in >> > in pci_configure_device(). Then we could drop the AER bus walk in >> > set_downstream_devices_error_reporting(). A bus walk like that is >> > always an issue for hotplug. >> >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-11 Thread Sinan Kaya
On 12/10/2015 5:37 PM, Bjorn Helgaas wrote: > On Thu, Dec 10, 2015 at 03:28:35PM -0500, Sinan Kaya wrote: >> Hi Bjorn, >> >> On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: >>> I'm sitting on this for the moment because if you have _HPP, it seems >>> like that should be enough to get SERR# forwarding

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-11 Thread Sinan Kaya
On 12/10/2015 5:37 PM, Bjorn Helgaas wrote: > On Thu, Dec 10, 2015 at 03:28:35PM -0500, Sinan Kaya wrote: >> Hi Bjorn, >> >> On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: >>> I'm sitting on this for the moment because if you have _HPP, it seems >>> like that should be enough to get SERR# forwarding

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-10 Thread Bjorn Helgaas
On Thu, Dec 10, 2015 at 03:28:35PM -0500, Sinan Kaya wrote: > Hi Bjorn, > > On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > > I'm sitting on this for the moment because if you have _HPP, it seems > > like that should be enough to get SERR# forwarding turned on, and if > > it's not, I'd like to

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-10 Thread Sinan Kaya
Hi Bjorn, On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > I'm sitting on this for the moment because if you have _HPP, it seems > like that should be enough to get SERR# forwarding turned on, and if > it's not, I'd like to understand why. So no hurry, but I'm waiting on > your investigation. > >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-10 Thread Sinan Kaya
Hi Bjorn, On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > I'm sitting on this for the moment because if you have _HPP, it seems > like that should be enough to get SERR# forwarding turned on, and if > it's not, I'd like to understand why. So no hurry, but I'm waiting on > your investigation. > >

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-10 Thread Bjorn Helgaas
On Thu, Dec 10, 2015 at 03:28:35PM -0500, Sinan Kaya wrote: > Hi Bjorn, > > On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > > I'm sitting on this for the moment because if you have _HPP, it seems > > like that should be enough to get SERR# forwarding turned on, and if > > it's not, I'd like to

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-05 Thread Sinan Kaya
On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > I'm sitting on this for the moment because if you have _HPP, it seems > like that should be enough to get SERR# forwarding turned on, and if > it's not, I'd like to understand why. So no hurry, but I'm waiting on > your investigation. > > Bjorn OK.

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-05 Thread Sinan Kaya
On 12/4/2015 4:06 PM, Bjorn Helgaas wrote: > I'm sitting on this for the moment because if you have _HPP, it seems > like that should be enough to get SERR# forwarding turned on, and if > it's not, I'd like to understand why. So no hurry, but I'm waiting on > your investigation. > > Bjorn OK.

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-04 Thread Bjorn Helgaas
Hi Sinan, On Wed, Dec 02, 2015 at 11:49:56AM -0500, Sinan Kaya wrote: > A PCIe card behind a switch is unable to report its errors when SERR# > forwarding is not enabled on the PCIe# switch's secondary interface > according to the spec. This patch enables SERR# forwarding when the PCI > header

Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-04 Thread Bjorn Helgaas
Hi Sinan, On Wed, Dec 02, 2015 at 11:49:56AM -0500, Sinan Kaya wrote: > A PCIe card behind a switch is unable to report its errors when SERR# > forwarding is not enabled on the PCIe# switch's secondary interface > according to the spec. This patch enables SERR# forwarding when the PCI > header

[PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-02 Thread Sinan Kaya
A PCIe card behind a switch is unable to report its errors when SERR# forwarding is not enabled on the PCIe# switch's secondary interface according to the spec. This patch enables SERR# forwarding when the PCI header type is bridge. Signed-off-by: Sinan Kaya ---

[PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches

2015-12-02 Thread Sinan Kaya
A PCIe card behind a switch is unable to report its errors when SERR# forwarding is not enabled on the PCIe# switch's secondary interface according to the spec. This patch enables SERR# forwarding when the PCI header type is bridge. Signed-off-by: Sinan Kaya ---