Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-28 Thread poza
On 2018-03-15 02:26, Keith Busch wrote: On Wed, Mar 14, 2018 at 02:52:30PM -0600, Keith Busch wrote: Reviewed-by: Keith Busch Whoops, I accidentally truncated my message. My correct tag: Reviewed-by: Keith Busch Hi Bjorn, Can this be merged ? Regards, Oza.

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-28 Thread poza
On 2018-03-15 02:26, Keith Busch wrote: On Wed, Mar 14, 2018 at 02:52:30PM -0600, Keith Busch wrote: Reviewed-by: Keith Busch Whoops, I accidentally truncated my message. My correct tag: Reviewed-by: Keith Busch Hi Bjorn, Can this be merged ? Regards, Oza.

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-15 Thread poza
On 2018-03-15 02:22, Keith Busch wrote: On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: Current DPC driver acknowledges the interrupt in deferred work, which works since MSI are edge triggered. But when MSI is disabled (e.g. pci=nomsi boot option) port service driver falls back

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-15 Thread poza
On 2018-03-15 02:22, Keith Busch wrote: On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: Current DPC driver acknowledges the interrupt in deferred work, which works since MSI are edge triggered. But when MSI is disabled (e.g. pci=nomsi boot option) port service driver falls back

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Keith Busch
On Wed, Mar 14, 2018 at 02:52:30PM -0600, Keith Busch wrote: > > Reviewed-by: Keith Busch

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Keith Busch
On Wed, Mar 14, 2018 at 02:52:30PM -0600, Keith Busch wrote: > > Reviewed-by: Keith Busch

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Keith Busch
On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: > Current DPC driver acknowledges the interrupt in deferred work, which works > since MSI are edge triggered. > > But when MSI is disabled (e.g. pci=nomsi boot option) port service > driver falls back to PCI legacy INT interrupt. > >

Re: [PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Keith Busch
On Wed, Mar 14, 2018 at 09:20:48PM +0530, Oza Pawandeep wrote: > Current DPC driver acknowledges the interrupt in deferred work, which works > since MSI are edge triggered. > > But when MSI is disabled (e.g. pci=nomsi boot option) port service > driver falls back to PCI legacy INT interrupt. > >

[PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Oza Pawandeep
Current DPC driver acknowledges the interrupt in deferred work, which works since MSI are edge triggered. But when MSI is disabled (e.g. pci=nomsi boot option) port service driver falls back to PCI legacy INT interrupt. With current code we do not acknowledge the interrupt back in dpc_irq() and

[PATCH v2] PCI/DPC: Fix PCI legacy interrupt acknowledgement

2018-03-14 Thread Oza Pawandeep
Current DPC driver acknowledges the interrupt in deferred work, which works since MSI are edge triggered. But when MSI is disabled (e.g. pci=nomsi boot option) port service driver falls back to PCI legacy INT interrupt. With current code we do not acknowledge the interrupt back in dpc_irq() and