Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-04-22 Thread Alex Williamson
On Fri, 19 Apr 2019 15:08:27 -0600 Alex Williamson wrote: > On Mon, 25 Mar 2019 17:25:02 -0500 > Bjorn Helgaas wrote: > > > On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: > > > A threaded IRQ with a NULL handler does not work with level-triggered > > > interrupts.

Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-04-19 Thread Bjorn Helgaas
On Fri, Apr 19, 2019 at 03:08:27PM -0600, Alex Williamson wrote: > On Mon, 25 Mar 2019 17:25:02 -0500, Bjorn Helgaas wrote: > > On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: > > > A threaded IRQ with a NULL handler does not work with level-triggered > > > interrupts.

Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-04-19 Thread Alex Williamson
On Mon, 25 Mar 2019 17:25:02 -0500 Bjorn Helgaas wrote: > On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: > > A threaded IRQ with a NULL handler does not work with level-triggered > > interrupts. request_threaded_irq() will return an error: > > > > genirq: Threaded irq

Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-03-25 Thread Bjorn Helgaas
[+cc Borislav] Hi Borislav, sorry; I meant to cc: you when I applied the patch below. I did add a Reported-by for you. On Mon, Mar 25, 2019 at 05:25:02PM -0500, Bjorn Helgaas wrote: > On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: > > A threaded IRQ with a NULL handler does

Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-03-25 Thread Alex G.
On 3/25/19 5:25 PM, Bjorn Helgaas wrote: On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: A threaded IRQ with a NULL handler does not work with level-triggered interrupts. request_threaded_irq() will return an error: genirq: Threaded irq requested with handler=NULL and

Re: [PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-03-25 Thread Bjorn Helgaas
On Fri, Mar 22, 2019 at 07:36:51PM -0500, Alexandru Gagniuc wrote: > A threaded IRQ with a NULL handler does not work with level-triggered > interrupts. request_threaded_irq() will return an error: > > genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 16 >

[PATCH v2] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-03-22 Thread Alexandru Gagniuc
A threaded IRQ with a NULL handler does not work with level-triggered interrupts. request_threaded_irq() will return an error: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 16 pcie_bw_notification: probe of :00:1b.0:pcie010 failed with error -22 For level