Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-05-21 Thread Remi Pommarel
Hi Lorenzo, On Tue, Apr 30, 2019 at 12:34:27PM +0100, Lorenzo Pieralisi wrote: > On Mon, Apr 29, 2019 at 05:32:35PM +0200, Remi Pommarel wrote: > > Hi Lorenzo, > > > > Sorry for duplicates I forgot to include everyone. > > > > On Thu, Apr 25, 2019 at 04:06:40PM +0100, Lorenzo Pieralisi wrote: >

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-30 Thread Lorenzo Pieralisi
On Mon, Apr 29, 2019 at 05:32:35PM +0200, Remi Pommarel wrote: > Hi Lorenzo, > > Sorry for duplicates I forgot to include everyone. > > On Thu, Apr 25, 2019 at 04:06:40PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Apr 25, 2019 at 04:23:53PM +0200, Remi Pommarel wrote: > > > Hi Lorenzo, > > > >

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-30 Thread Remi Pommarel
On Mon, Apr 29, 2019 at 02:45:32PM -0500, Bjorn Helgaas wrote: > On Fri, Apr 26, 2019 at 12:27:57AM +0200, Remi Pommarel wrote: > > On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote: > > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > > > > It sounds like reading and

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-29 Thread Bjorn Helgaas
On Fri, Apr 26, 2019 at 12:27:57AM +0200, Remi Pommarel wrote: > On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote: > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > > It sounds like reading and/or writing some registers during a retrain > > causes some sort of EL1 e

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-29 Thread Remi Pommarel
Hi Lorenzo, Sorry for duplicates I forgot to include everyone. On Thu, Apr 25, 2019 at 04:06:40PM +0100, Lorenzo Pieralisi wrote: > On Thu, Apr 25, 2019 at 04:23:53PM +0200, Remi Pommarel wrote: > > Hi Lorenzo, > > > > On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lorenzo Pieralisi wrote: > > > On S

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-25 Thread Remi Pommarel
Hi Bjorn, On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote: > Hi Remi, > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA > > config register does not reflect the actual link training state an

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-25 Thread Bjorn Helgaas
Hi Remi, On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA > config register does not reflect the actual link training state and is > always cleared. The Link Training and Status State Machine (LTSSM) flag > in

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-25 Thread Lorenzo Pieralisi
On Thu, Apr 25, 2019 at 04:23:53PM +0200, Remi Pommarel wrote: > Hi Lorenzo, > > On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lorenzo Pieralisi wrote: > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > > > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA > > >

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-25 Thread Remi Pommarel
Hi Lorenzo, On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lorenzo Pieralisi wrote: > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA > > config register does not reflect the actual link training state and is > >

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-25 Thread Lorenzo Pieralisi
On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote: > The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA > config register does not reflect the actual link training state and is > always cleared. The Link Training and Status State Machine (LTSSM) flag > in LMI config

[PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-03-16 Thread Remi Pommarel
The PCI_EXP_LNKSTA_LT flag in the emulated root device's PCI_EXP_LNKSTA config register does not reflect the actual link training state and is always cleared. The Link Training and Status State Machine (LTSSM) flag in LMI config register could be used as a link training indicator. Indeed if the LTS