Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check

2020-09-22 Thread Colin Ian King
On 22/09/2020 13:43, Jim Quinlan wrote: > On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring wrote: >> >>> The error return ret is not being check with an if statement and >> >> Wording alternative: >> The return value from a call of the function “brcm_phy_start” was not >> checked and >> >> >>> V2:

Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check

2020-09-22 Thread Jim Quinlan
On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring wrote: > > > The error return ret is not being check with an if statement and > > Wording alternative: > The return value from a call of the function “brcm_phy_start” was not checked > and > > > > V2: disable clock as noted by Florian Fainelli and su