Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-11 Thread Guenter Roeck
On Thu, Dec 11, 2014 at 02:00:06PM -0700, Bjorn Helgaas wrote: > On Thu, Dec 11, 2014 at 1:45 PM, Guenter Roeck wrote: > > On Thu, Dec 11, 2014 at 01:26:47PM -0700, Bjorn Helgaas wrote: > >> On Thu, Dec 11, 2014 at 9:38 AM, Guenter Roeck wrote: > >> > On Wed, Dec 10, 2014 at 05:26:30PM -0700, Bjo

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-11 Thread Guenter Roeck
On Thu, Dec 11, 2014 at 01:26:47PM -0700, Bjorn Helgaas wrote: > On Thu, Dec 11, 2014 at 9:38 AM, Guenter Roeck wrote: > > On Wed, Dec 10, 2014 at 05:26:30PM -0700, Bjorn Helgaas wrote: > >> On Thu, Nov 20, 2014 at 02:54:24PM -0800, Rajat Jain wrote: > >> > While removing a card, we can't assume t

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-11 Thread Bjorn Helgaas
On Thu, Dec 11, 2014 at 1:45 PM, Guenter Roeck wrote: > On Thu, Dec 11, 2014 at 01:26:47PM -0700, Bjorn Helgaas wrote: >> On Thu, Dec 11, 2014 at 9:38 AM, Guenter Roeck wrote: >> > On Wed, Dec 10, 2014 at 05:26:30PM -0700, Bjorn Helgaas wrote: >> >> On Thu, Nov 20, 2014 at 02:54:24PM -0800, Rajat

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-11 Thread Bjorn Helgaas
On Thu, Dec 11, 2014 at 9:38 AM, Guenter Roeck wrote: > On Wed, Dec 10, 2014 at 05:26:30PM -0700, Bjorn Helgaas wrote: >> On Thu, Nov 20, 2014 at 02:54:24PM -0800, Rajat Jain wrote: >> > While removing a card, we can't assume the presence to mean that the >> > access to card is OK. That is because

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-11 Thread Guenter Roeck
On Wed, Dec 10, 2014 at 05:26:30PM -0700, Bjorn Helgaas wrote: > On Thu, Nov 20, 2014 at 02:54:24PM -0800, Rajat Jain wrote: > > While removing a card, we can't assume the presence to mean that the > > access to card is OK. That is because the cause of removal may be a > > link down event, and the

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-10 Thread Bjorn Helgaas
On Thu, Nov 20, 2014 at 02:54:24PM -0800, Rajat Jain wrote: > While removing a card, we can't assume the presence to mean that the > access to card is OK. That is because the cause of removal may be a > link down event, and the card may still be physically present. Thus, > instead of presence, use

Re: [PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-12-07 Thread Rajat Jain
Hello Bjorn, Just checking if you got a chance to look at this. Thanks, Rajat On Thu, Nov 20, 2014 at 2:54 PM, Rajat Jain wrote: > While removing a card, we can't assume the presence to mean that the > access to card is OK. That is because the cause of removal may be a > link down event, and

[PATCH v2] PCI: pciehp: Check link state before accessing device during removal

2014-11-20 Thread Rajat Jain
While removing a card, we can't assume the presence to mean that the access to card is OK. That is because the cause of removal may be a link down event, and the card may still be physically present. Thus, instead of presence, use the link state to decide whether or not it is OK to access the card