Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-12 Thread Lukas Wunner
On Thu, Feb 09, 2017 at 05:32:54AM +0100, Lukas Wunner wrote: > On Wed, Feb 08, 2017 at 11:57:36AM -0600, Bjorn Helgaas wrote: > > On Tue, Feb 07, 2017 at 07:21:01AM +0100, Lukas Wunner wrote: > > > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > > > On Mon, Feb 06, 2017 at 10:20

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-08 Thread Lukas Wunner
On Wed, Feb 08, 2017 at 11:57:36AM -0600, Bjorn Helgaas wrote: > On Tue, Feb 07, 2017 at 07:21:01AM +0100, Lukas Wunner wrote: > > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > > > > On Mon, Feb 06, 2017 at 11:54

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-08 Thread Bjorn Helgaas
On Wed, Feb 08, 2017 at 05:23:54AM +0100, Lukas Wunner wrote: > On Tue, Feb 07, 2017 at 05:04:45PM +0100, Rafael J. Wysocki wrote: > > The bottom line, in any case, is that the current code causes problems to > > happen somewhere and as a rule we don't release code that is known to > > cause probl

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-08 Thread Bjorn Helgaas
On Tue, Feb 07, 2017 at 07:21:01AM +0100, Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > > > What is the hotplug event tha

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-08 Thread Rafael J. Wysocki
On Wednesday, February 08, 2017 05:23:54 AM Lukas Wunner wrote: > On Tue, Feb 07, 2017 at 05:04:45PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, February 07, 2017 07:21:01 AM Lukas Wunner wrote: > > > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > > > On Mon, Feb 06, 2017 at

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-07 Thread Lukas Wunner
On Tue, Feb 07, 2017 at 05:04:45PM +0100, Rafael J. Wysocki wrote: > On Tuesday, February 07, 2017 07:21:01 AM Lukas Wunner wrote: > > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > > > > On Mon, Feb 06, 2017 at 1

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-07 Thread Rafael J. Wysocki
On Tuesday, February 07, 2017 07:26:59 AM Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 10:52:12PM +0100, Rafael J. Wysocki wrote: > > On Monday, February 06, 2017 10:20:41 PM Lukas Wunner wrote: > > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > > > On Mon, Feb 06, 2017 at 06

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-07 Thread Rafael J. Wysocki
On Tuesday, February 07, 2017 07:21:01 AM Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > > > What is the hotplug event tha

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Lukas Wunner
On Mon, Feb 06, 2017 at 10:52:12PM +0100, Rafael J. Wysocki wrote: > On Monday, February 06, 2017 10:20:41 PM Lukas Wunner wrote: > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > > On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > > > > Since commit 68db9bc81436

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Lukas Wunner
On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote: > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > > What is the hotplug event that causes generation of this wakeup event? > > > > If you had read all

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Bjorn Helgaas
On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > > > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > > > hotplug ports") we ru

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Rafael J. Wysocki
On Monday, February 06, 2017 10:20:41 PM Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > > > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > > > hotplug ports") we run

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Rafael J. Wysocki
On Monday, February 06, 2017 10:20:41 PM Lukas Wunner wrote: > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > > On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > > > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > > > hotplug ports") we run

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Lukas Wunner
On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote: > On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > > hotplug ports") we runtime suspend a hotplug port to D3hot when all its > > children are ru

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Bjorn Helgaas
On Mon, Feb 06, 2017 at 06:54:37AM +0100, Lukas Wunner wrote: > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > hotplug ports") we runtime suspend a hotplug port to D3hot when all its > children are runtime suspended or none are present. > > When runtime suspending the p

Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-06 Thread Rafael J. Wysocki
On Monday, February 06, 2017 06:54:37 AM Lukas Wunner wrote: > Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe > hotplug ports") we runtime suspend a hotplug port to D3hot when all its > children are runtime suspended or none are present. > > When runtime suspending the po

[PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend

2017-02-05 Thread Lukas Wunner
Since commit 68db9bc81436 ("PCI: pciehp: Add runtime PM support for PCIe hotplug ports") we runtime suspend a hotplug port to D3hot when all its children are runtime suspended or none are present. When runtime suspending the port the PCI core automatically enables PME: pci_pm_runtime_suspend()