Re: [PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq

2014-07-28 Thread Jisheng Zhang
Hi Thierry, On Mon, 28 Jul 2014 08:35:50 -0700 Thierry Reding wrote: > On Mon, Jul 28, 2014 at 11:45:42AM +0800, Jisheng Zhang wrote: > > We should call tegra_msi_free() to free the msi bit if > > irq_create_mapping() fails. And we need to dispose the irq mapping > > during irq teardown. > > "M

Re: [PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq

2014-07-28 Thread Thierry Reding
On Mon, Jul 28, 2014 at 11:45:42AM +0800, Jisheng Zhang wrote: > We should call tegra_msi_free() to free the msi bit if > irq_create_mapping() fails. And we need to dispose the irq mapping > during irq teardown. "MSI" and "IRQ" please. > diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/hos

[PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq

2014-07-27 Thread Jisheng Zhang
We should call tegra_msi_free() to free the msi bit if irq_create_mapping() fails. And we need to dispose the irq mapping during irq teardown. Signed-off-by: Jisheng Zhang --- drivers/pci/host/pci-tegra.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pci/hos