Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Santosh Shilimkar
On Thursday 11 September 2014 06:07 PM, Doug Anderson wrote: > Santosh, > > On Thu, Sep 11, 2014 at 2:31 PM, Santosh Shilimkar > wrote: >>> +Required properties: >>> +- compatible: should be one of: >>> + - "rockchip,rk3188-iodomain" for rk3188 >>> + - "rockchip,rk3288-iodomain" for rk3288 >>

Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Doug Anderson
Santosh, On Thu, Sep 11, 2014 at 2:31 PM, Santosh Shilimkar wrote: >> +Required properties: >> +- compatible: should be one of: >> + - "rockchip,rk3188-iodomain" for rk3188 >> + - "rockchip,rk3288-iodomain" for rk3288 > The key word 'voltage' is missing from the compatible. iodomain itself >

Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Santosh Shilimkar
On Thursday 11 September 2014 05:00 PM, Doug Anderson wrote: > From: Heiko Stübner > > IO domain voltages on some Rockchip SoCs are variable but need to be > kept in sync between the regulators and the SoC using a special > register. > > A specific example using rk3288: > - If the regulator

[PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Doug Anderson
From: Heiko Stübner IO domain voltages on some Rockchip SoCs are variable but need to be kept in sync between the regulators and the SoC using a special register. A specific example using rk3288: - If the regulator hooked up to a pin like SDMMC0_VDD is 3.3V then bit 7 of GRF_IO_VSEL needs to

Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Santosh Shilimkar
On Thursday 11 September 2014 05:00 PM, Doug Anderson wrote: From: Heiko Stübner he...@sntech.de IO domain voltages on some Rockchip SoCs are variable but need to be kept in sync between the regulators and the SoC using a special register. A specific example using rk3288: - If the

Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Doug Anderson
Santosh, On Thu, Sep 11, 2014 at 2:31 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: +Required properties: +- compatible: should be one of: + - rockchip,rk3188-iodomain for rk3188 + - rockchip,rk3288-iodomain for rk3288 The key word 'voltage' is missing from the compatible. iodomain

Re: [PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Santosh Shilimkar
On Thursday 11 September 2014 06:07 PM, Doug Anderson wrote: Santosh, On Thu, Sep 11, 2014 at 2:31 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: +Required properties: +- compatible: should be one of: + - rockchip,rk3188-iodomain for rk3188 + - rockchip,rk3288-iodomain for rk3288

[PATCH v2] PM / AVS: rockchip-io: add driver handling Rockchip io domains

2014-09-11 Thread Doug Anderson
From: Heiko Stübner he...@sntech.de IO domain voltages on some Rockchip SoCs are variable but need to be kept in sync between the regulators and the SoC using a special register. A specific example using rk3288: - If the regulator hooked up to a pin like SDMMC0_VDD is 3.3V then bit 7 of