On Mon, Apr 01, 2019 at 10:01:30AM -0400, Will Cunningham wrote:
> Removed unnecessary parentheses.
>
> Signed-off-by: Will Cunningham
> ---
> Changes in v2:
> - Removed a typo from the commit message.
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8
> 1 file changed, 4 insertions(
Removed unnecessary parentheses.
Signed-off-by: Will Cunningham
---
Changes in v2:
- Removed a typo from the commit message.
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers
On 21/02/17 17:25, Cheah Kok Cheong wrote:
Fix checkpatch warning "Avoid multiple line dereference"
using a pointer variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
V2:
-Use pointer instead of normal variable - Ian
-Variable is to be used as "write destination" and
not as "rea
Fix checkpatch warning "Avoid multiple line dereference"
using a pointer variable to avoid line wrap.
Signed-off-by: Cheah Kok Cheong
---
V2:
-Use pointer instead of normal variable - Ian
-Variable is to be used as "write destination" and
not as "read source" - Ian
drivers/staging/comedi/driv
On Thu, Feb 16, 2017 at 10:10:34AM +, Ian Abbott wrote:
> On 15/02/17 06:05, Cheah Kok Cheong wrote:
> >On Mon, Feb 13, 2017 at 11:14:14AM +, Ian Abbott wrote:
> >>On 11/02/17 10:37, Cheah Kok Cheong wrote:
> [snip]
> >>>+static void __exit comedi_test_exit(void)
> >>>+{
> >>>+ comedi_auto
On 15/02/17 06:05, Cheah Kok Cheong wrote:
On Mon, Feb 13, 2017 at 11:14:14AM +, Ian Abbott wrote:
On 11/02/17 10:37, Cheah Kok Cheong wrote:
[snip]
+static void __exit comedi_test_exit(void)
+{
+ comedi_auto_unconfig(ctdev);
+
+ device_destroy(ctcls, MKDEV(0, 0));
+
+ cl
On Mon, Feb 13, 2017 at 11:14:14AM +, Ian Abbott wrote:
> On 11/02/17 10:37, Cheah Kok Cheong wrote:
> >+static int __init comedi_test_init(void)
> >+{
> >+int ret;
> >+
> >+ret = comedi_driver_register(&waveform_driver);
> >+if (ret) {
> >+pr_err("comedi_test: unable to
On 11/02/17 10:37, Cheah Kok Cheong wrote:
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achiev
Currently this module needs to be manually configured by COMEDI
userspace tool before the test waveform can be read by a COMEDI
compatible application.
This patch adds auto-configuration capability and makes it the default
loading option. This is achieved by creating a device during init
to stand
On 30/01/15 12:10, Dan Carpenter wrote:
On Fri, Jan 30, 2015 at 10:29:44AM +, Ian Abbott wrote:
@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
ul_Command1 = ((ul_Command1 & 0xF9FDul) |
On Fri, Jan 30, 2015 at 10:29:44AM +, Ian Abbott wrote:
> >@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> > ul_Command1 = ((ul_Command1 & 0xF9FDul) | 1 << 1);
> > outl(ul_Command1, dev->
Ian Abbott wrote:
On 29/01/15 22:50, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
dr
On 29/01/15 22:50, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:43, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:40, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:34, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:30, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:25, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:15, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/usbduxsigma.c |4
1 file changed
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/rtd520.c |4
1 file changed, 4 d
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/dyna_pci10xx.c |6 +-
1 file chan
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/addi_apci_3501.c |3 +--
1 file chang
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c |3 +--
1
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/mite.c |2 --
1 file changed, 2 delet
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/jr3_pci.c |2 --
1 file changed, 2 de
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 12 ++---
On Wednesday, January 28, 2015 2:49 PM, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
>
2015-01-28 22:48 GMT+01:00 Hartley Sweeten :
> On Wednesday, January 28, 2015 2:49 PM, Rickard Strandqvist wrote:
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called
On Sat, Oct 18, 2014 at 04:35:08PM +0200, Rickard Strandqvist wrote:
> Changed from using strncat to strlcat to simplify the code
>
> Signed-off-by: Rickard Strandqvist
> Reviewed-by: Ian Abbott
> Reviewed-by: H Hartley Sweeten
> ---
> drivers/staging/comedi/drivers/comedi_bond.c |9 +++---
Changed from using strncat to strlcat to simplify the code
Signed-off-by: Rickard Strandqvist
Reviewed-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/comedi_bond.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/
On Fri, Apr 04, 2014 at 06:44:44PM +0300, Kumar Amit Mehta wrote:
> Kernel style is that if one side of the if else statement gets has curly
> braces then both side should have them.
>
> Signed-off-by: Kumar Amit Mehta
Looks good, thanks.
regards,
dan carpenter
--
To unsubscribe from this list
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812
On Mon, Jan 06, 2014 at 11:08:14PM -0500, Aruna-Hewapathirane wrote:
> Fixed a coding style issue in ke_counter.c
You forgot a valid Subject: line :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
Fixed a coding style issue in ke_counter.c
Signed-off-by: Aruna Hewapathirane
---
drivers/staging/comedi/drivers/ke_counter.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ke_counter.c
b/drivers/staging/comedi/drivers/ke_counter.c
ind
On 2013-02-22 14:26, Kumar amit mehta wrote:
On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote:
On 2013-02-22 06:07, Kumar Amit Mehta wrote:
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
Loo
On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote:
> On 2013-02-22 06:07, Kumar Amit Mehta wrote:
> >This patch fixes an instance of DMA buffer on stack(being passed to
> >usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
> >
>
> Looks good here too.
>
> Reviewed-by:
On 2013-02-22 06:07, Kumar Amit Mehta wrote:
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
Looks good here too.
Reviewed-by: Ian Abbott
Would you mind doing the same for usbdux.c and usbduxfast.c?
Looks good.
Reviewed-by: Dan Carpenter
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tu
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
Signed-off-by: Kumar Amit Mehta
---
drivers/staging/comedi/drivers/usbduxsigma.c | 27 --
1 file changed, 17 insertions(+), 10 dele
40 matches
Mail list logo
