On 05.01.2014 21:47, Dan Carpenter wrote:
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
-static u16 name_hash(void *key, u16
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
> -static u16 name_hash(void *key, u16 max_bucket)
> +static u32 name_hash(const void
From: Ivaylo Dimitrov
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/gen/gh.c | 148
drivers/staging/tidspbridge/include/dspbridge/gh.h | 12 +-
From: Ivaylo Dimitrov freemangor...@abv.bg
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov ivo.g.dimitrov...@gmail.com
---
drivers/staging/tidspbridge/gen/gh.c | 148
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
-static u16 name_hash(void *key, u16 max_bucket)
+static u32 name_hash(const void
On 05.01.2014 21:47, Dan Carpenter wrote:
Looks much nicer. I had a few tiny comments, but those could be
addressed in later patches. (There is a lot of work to be done on this
driver).
On Sun, Jan 05, 2014 at 08:58:12PM +0200, Ivaylo Dimitrov wrote:
-static u16 name_hash(void *key, u16
> + u32 val_size;
> + DECLARE_HASHTABLE(hash_table, GH_HASH_ORDER);
> + u32 (*hash)(void *);
> + bool (*match)(void *, void *);
> + void (*delete)(void *);
I forgot to say, put the parameter name in the declaration.
+ u32 (*hash)(void *key);
+ bool (*match)(void
+ u32 val_size;
+ DECLARE_HASHTABLE(hash_table, GH_HASH_ORDER);
+ u32 (*hash)(void *);
+ bool (*match)(void *, void *);
+ void (*delete)(void *);
I forgot to say, put the parameter name in the declaration.
+ u32 (*hash)(void *key);
+ bool (*match)(void *key,
From: Ivaylo Dimitrov
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/gen/gh.c | 141 +++-
drivers/staging/tidspbridge/include/dspbridge/gh.h |6 +-
From: Ivaylo Dimitrov freemangor...@abv.bg
Use upstream hashtable implementation instead of generic code
Signed-off-by: Ivaylo Dimitrov freemangor...@abv.bg
---
drivers/staging/tidspbridge/gen/gh.c | 141 +++-
drivers/staging/tidspbridge/include/dspbridge/gh.h |
10 matches
Mail list logo