Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-24 Thread Benson Leung
On Sat, Mar 24, 2018 at 12:06:20PM -0400, Alan Stern wrote: > > + dev_info(&udev->dev, > > +"New USB device found, idVendor=%04x, idProduct=%04x, > > bcdDevice=%2x.%02x\n", > > +le16_to_cpu(udev->descriptor.idVendor), > > Unnecessary and incorrect whitespace changes. T

Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-24 Thread Alan Stern
On Fri, 23 Mar 2018, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Match the %2x.%02x formatting that's used by lsusb -v

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Benson Leung
Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung --