Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 15:58, Thomas Abraham wrote: > On 14 March 2013 17:31, Alexander Graf wrote: >> >> On 14.03.2013, at 05:19, Thomas Abraham wrote: >> >>> On 14 March 2013 05:29, Alexander Graf wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Doug Anderson
Hi, On Thu, Mar 14, 2013 at 7:58 AM, Thomas Abraham wrote: >> I can see your point, but as I mentioned earlier there seems to be some >> timing issue here. By simply doing the reset a few ms earlier (in the first >> probe, before the driver detects that it needs to defer probing), I already

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Thomas Abraham
On 14 March 2013 17:31, Alexander Graf wrote: > > On 14.03.2013, at 05:19, Thomas Abraham wrote: > >> On 14 March 2013 05:29, Alexander Graf wrote: >>> On my Exynos 5 based Arndale system, I need to pull the reset line down >>> and then let it go up again to actually perform a reset. Without

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 04:38, Doug Anderson wrote: > Alexander, > > On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote: >> On my Exynos 5 based Arndale system, I need to pull the reset line down >> and then let it go up again to actually perform a reset. Without that >> reset, I can't find any

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 05:19, Thomas Abraham wrote: > On 14 March 2013 05:29, Alexander Graf wrote: >> On my Exynos 5 based Arndale system, I need to pull the reset line down >> and then let it go up again to actually perform a reset. Without that >> reset, I can't find any USB hubs on my bus,

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 05:19, Thomas Abraham wrote: On 14 March 2013 05:29, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus,

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 04:38, Doug Anderson wrote: Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Thomas Abraham
On 14 March 2013 17:31, Alexander Graf ag...@suse.de wrote: On 14.03.2013, at 05:19, Thomas Abraham wrote: On 14 March 2013 05:29, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Doug Anderson
Hi, On Thu, Mar 14, 2013 at 7:58 AM, Thomas Abraham thomas.abra...@linaro.org wrote: I can see your point, but as I mentioned earlier there seems to be some timing issue here. By simply doing the reset a few ms earlier (in the first probe, before the driver detects that it needs to defer

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Alexander Graf
On 14.03.2013, at 15:58, Thomas Abraham wrote: On 14 March 2013 17:31, Alexander Graf ag...@suse.de wrote: On 14.03.2013, at 05:19, Thomas Abraham wrote: On 14 March 2013 05:29, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Thomas Abraham
On 14 March 2013 05:29, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > We also only

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller >

[PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller useless. We also only need to reset the line after the phy node has been found.

[PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller useless. We also only need to reset the line after the phy node has been found.

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Thomas Abraham
On 14 March 2013 05:29, Alexander Graf ag...@suse.de wrote: On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller useless. We also