Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread David Howells
Andrew Morton wrote: > > - * allocate an AFS inode struct from our slab cache > > + * allocate an AFS inode struct > > */ > > static struct inode *afs_alloc_inode(struct super_block *sb) > > { > > err, this was obviously a product of senility. My comment, or your comment on my comment?

Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread Andrew Morton
On Fri, 21 Feb 2014 13:47:16 -0800 Andrew Morton wrote: > --- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix > +++ a/fs/afs/super.c > @@ -474,7 +474,7 @@ static void afs_i_init_once(void *_vnode > } > > /* > - * allocate an AFS inode struct from our slab cache > + * allocate

Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread Andrew Morton
On Thu, 20 Feb 2014 22:00:39 +0800 Fabian Frederick wrote: > This patch calls zalloc for explicit zero fill and removes all memset 0. > May as well fix the deceitful comment while we're in there. --- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix +++ a/fs/afs/super.c @@ -474,7

Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread Andrew Morton
On Thu, 20 Feb 2014 22:00:39 +0800 Fabian Frederick f...@skynet.be wrote: This patch calls zalloc for explicit zero fill and removes all memset 0. May as well fix the deceitful comment while we're in there. --- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix +++

Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread Andrew Morton
On Fri, 21 Feb 2014 13:47:16 -0800 Andrew Morton a...@linux-foundation.org wrote: --- a/fs/afs/super.c~afs-afs_alloc_inode-use-kmem_cache_zalloc-fix +++ a/fs/afs/super.c @@ -474,7 +474,7 @@ static void afs_i_init_once(void *_vnode } /* - * allocate an AFS inode struct from our slab

Re: [PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-21 Thread David Howells
Andrew Morton a...@linux-foundation.org wrote: - * allocate an AFS inode struct from our slab cache + * allocate an AFS inode struct */ static struct inode *afs_alloc_inode(struct super_block *sb) { err, this was obviously a product of senility. My comment, or your comment on my

[PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Fabian Frederick
This patch calls zalloc for explicit zero fill and removes all memset 0. Signed-off-by: Fabian Frederick --- fs/afs/super.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index c486155..aff91ee 100644 --- a/fs/afs/super.c +++

[PATCH v2] afs: afs_alloc_inode: use kmem_cache_zalloc

2014-02-20 Thread Fabian Frederick
This patch calls zalloc for explicit zero fill and removes all memset 0. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/afs/super.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index c486155..aff91ee 100644 --- a/fs/afs/super.c