Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-06 Thread Miroslav Benes
On Mon, 5 Nov 2018, Will Deacon wrote: > On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: > > Instead of saving a pointer to the .plt and .init.plt sections to apply > > plt-based relocations, save and use their section indices instead. > > > > The mod->arch.{core,init}.plt pointers

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-06 Thread Miroslav Benes
On Mon, 5 Nov 2018, Will Deacon wrote: > On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: > > Instead of saving a pointer to the .plt and .init.plt sections to apply > > plt-based relocations, save and use their section indices instead. > > > > The mod->arch.{core,init}.plt pointers

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Jessica Yu
+++ Will Deacon [05/11/18 19:26 +]: On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: Instead of saving a pointer to the .plt and .init.plt sections to apply plt-based relocations, save and use their section indices instead. The mod->arch.{core,init}.plt pointers were problematic

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Jessica Yu
+++ Will Deacon [05/11/18 19:26 +]: On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: Instead of saving a pointer to the .plt and .init.plt sections to apply plt-based relocations, save and use their section indices instead. The mod->arch.{core,init}.plt pointers were problematic

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Will Deacon
On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: > Instead of saving a pointer to the .plt and .init.plt sections to apply > plt-based relocations, save and use their section indices instead. > > The mod->arch.{core,init}.plt pointers were problematic for livepatch > because they

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Will Deacon
On Mon, Nov 05, 2018 at 07:53:23PM +0100, Jessica Yu wrote: > Instead of saving a pointer to the .plt and .init.plt sections to apply > plt-based relocations, save and use their section indices instead. > > The mod->arch.{core,init}.plt pointers were problematic for livepatch > because they

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Ard Biesheuvel
On 5 November 2018 at 19:53, Jessica Yu wrote: > Instead of saving a pointer to the .plt and .init.plt sections to apply > plt-based relocations, save and use their section indices instead. > > The mod->arch.{core,init}.plt pointers were problematic for livepatch > because they pointed within

Re: [PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Ard Biesheuvel
On 5 November 2018 at 19:53, Jessica Yu wrote: > Instead of saving a pointer to the .plt and .init.plt sections to apply > plt-based relocations, save and use their section indices instead. > > The mod->arch.{core,init}.plt pointers were problematic for livepatch > because they pointed within

[PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Jessica Yu
Instead of saving a pointer to the .plt and .init.plt sections to apply plt-based relocations, save and use their section indices instead. The mod->arch.{core,init}.plt pointers were problematic for livepatch because they pointed within temporary section headers (provided by the module loader

[PATCH v2] arm64/module: use plt section indices for relocations

2018-11-05 Thread Jessica Yu
Instead of saving a pointer to the .plt and .init.plt sections to apply plt-based relocations, save and use their section indices instead. The mod->arch.{core,init}.plt pointers were problematic for livepatch because they pointed within temporary section headers (provided by the module loader