Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-06 Thread Daniel Thompson
On Tue, May 05, 2020 at 04:09:16PM +0100, Will Deacon wrote: > On Tue, May 05, 2020 at 03:15:29PM +0100, Daniel Thompson wrote: > > On Mon, May 04, 2020 at 09:48:04PM +0100, Will Deacon wrote: > > > On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > > > > diff --git a/arch/arm64/inc

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-05 Thread Will Deacon
On Mon, 4 May 2020 18:05:18 +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is flawed:

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-05 Thread Will Deacon
On Tue, May 05, 2020 at 03:15:29PM +0100, Daniel Thompson wrote: > On Mon, May 04, 2020 at 09:48:04PM +0100, Will Deacon wrote: > > On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > > > diff --git a/arch/arm64/include/asm/cacheflush.h > > > b/arch/arm64/include/asm/cacheflush.h >

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-05 Thread Daniel Thompson
On Mon, May 04, 2020 at 09:48:04PM +0100, Will Deacon wrote: > On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > > trap handler is running because issuing IPIs is unsafe (and not needed) > > in this execu

Re: [PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-04 Thread Will Deacon
On Mon, May 04, 2020 at 06:05:18PM +0100, Daniel Thompson wrote: > flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb > trap handler is running because issuing IPIs is unsafe (and not needed) > in this execution context. However the current test, based on > kgdb_connected is

[PATCH v2] arm64: cacheflush: Fix KGDB trap detection

2020-05-04 Thread Daniel Thompson
flush_icache_range() contains a bodge to avoid issuing IPIs when the kgdb trap handler is running because issuing IPIs is unsafe (and not needed) in this execution context. However the current test, based on kgdb_connected is flawed: it both over-matches and under-matches. The over match occurs be