Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-29 Thread Maxime Coquelin
Hi Peter, On 04/20/2015 03:41 PM, Peter Griffin wrote: Brian noticed while working on another SATA driver that uses libahci_platform, an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host()

Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-29 Thread Maxime Coquelin
Hi Peter, On 04/20/2015 03:41 PM, Peter Griffin wrote: Brian noticed while working on another SATA driver that uses libahci_platform, an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host()

Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-22 Thread Brian Norris
On Mon, Apr 20, 2015 at 02:41:04PM +0100, Peter Griffin wrote: > Brian - I'm not sure of the correct patch etiquette here. Currently I have > taken authorship of the patch and added a "Suggested-by" tag on the V2. > Maybe I should have also kept your "Signed-off-by" or done something else? >

Re: [PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-22 Thread Brian Norris
On Mon, Apr 20, 2015 at 02:41:04PM +0100, Peter Griffin wrote: Brian - I'm not sure of the correct patch etiquette here. Currently I have taken authorship of the patch and added a Suggested-by tag on the V2. Maybe I should have also kept your Signed-off-by or done something else? Please let me

[PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Hi Tejun / Brian, I tested the initial version of this patch (see http://patchwork.ozlabs.org/patch/459422/) on stih410 hardware, however it introduced a NULL ptr dereference, as plat_data isn't set until ahci_platform_init_host() but plat_data was being used before this in the

[PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Brian noticed while working on another SATA driver that uses libahci_platform, an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() -> ata_host_alloc_pinfo() -> ata_host_alloc()

[PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Brian noticed while working on another SATA driver that uses libahci_platform, an error in this driver; it tries to the the driver data for its device, while libata also thinks it can set the driver data. See: ahci_platform_init_host() - ata_host_alloc_pinfo() - ata_host_alloc()

[PATCH v2] ata: ahci_st: fixup layering violations / drvdata errors

2015-04-20 Thread Peter Griffin
Hi Tejun / Brian, I tested the initial version of this patch (see http://patchwork.ozlabs.org/patch/459422/) on stih410 hardware, however it introduced a NULL ptr dereference, as plat_data isn't set until ahci_platform_init_host() but plat_data was being used before this in the