Re: [PATCH v2] ata: use generic power management

2020-07-28 Thread Jens Axboe
On 7/27/20 11:17 PM, Vaibhav Gupta wrote: > On Mon, Jul 27, 2020 at 02:30:03PM -0600, Jens Axboe wrote: >> On 7/27/20 12:11 PM, Vaibhav Gupta wrote: >>> On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > On Mon, Jul 27, 2020 at

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Vaibhav Gupta
On Mon, Jul 27, 2020 at 02:30:03PM -0600, Jens Axboe wrote: > On 7/27/20 12:11 PM, Vaibhav Gupta wrote: > > On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: > >> On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > >>> On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > On 7/27/20

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Jens Axboe
On 7/27/20 12:11 PM, Vaibhav Gupta wrote: > On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: >> On 7/27/20 11:51 AM, Vaibhav Gupta wrote: >>> On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > The patch is compile-tested

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Vaibhav Gupta
On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: > On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > > On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > >> On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > >>> The patch is compile-tested only. > >> > >> Please test and verify actual

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Jens Axboe
On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: >> On 7/27/20 11:40 AM, Vaibhav Gupta wrote: >>> The patch is compile-tested only. >> >> Please test and verify actual functionality, if you're serious about >> potentially getting this into the

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Vaibhav Gupta
On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > > The patch is compile-tested only. > > Please test and verify actual functionality, if you're serious about > potentially getting this into the kernel. > Hello Jens, Sadly I don't have the

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Jens Axboe
On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > The patch is compile-tested only. Please test and verify actual functionality, if you're serious about potentially getting this into the kernel. -- Jens Axboe

Re: [PATCH v2] ata: use generic power management

2020-07-27 Thread Vaibhav Gupta
The patch is compile-tested only. Thanks Vaibhav Gupta

[PATCH v2] ata: use generic power management

2020-07-27 Thread Vaibhav Gupta
use generic power management Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct