Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-11-13 Thread Abhishek Kumar
Hi All, The V2 patch now has good comments and probably spinning off a new V3 might be a good idea. Here are a few comments to the discussion. In response to Doug's comment > case WMI_TLV_TAG_FIRST_ARRAY_ENUM: > arg->service_map_ext_len = 0; > arg->service_map_ext = NULL; > return 0; Since

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-11-05 Thread Kalle Valo
Doug Anderson writes: >> static int ath10k_wmi_tlv_op_pull_svc_avail(struct ath10k *ar, >> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c >> b/drivers/net/wireless/ath/ath10k/wmi.c >> index 1fa7107..2e4b561 100644 >> --- a/drivers/net/wireless/ath/ath10k/wmi.c >> +++ b/drivers/net/wireless/

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-11-05 Thread Kalle Valo
Rakesh Pillai writes: > The wmi service available event has been > extended to contain extra 128 bit for new services > to be indicated by firmware. > > Currently the presence of any optional TLVs in > the wmi service available event leads to a parsing > error with the below error message: > ath1

RE: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-10-29 Thread Rakesh Pillai
> -Original Message- > From: Doug Anderson > Sent: Thursday, October 29, 2020 12:15 AM > To: Rakesh Pillai > Cc: ath10k ; linux-wireless wirel...@vger.kernel.org>; LKML ; Abhishek > Kumar ; Brian Norris > Subject: Re: [PATCH v2] ath10k: Fix the parsing er

Re: [PATCH v2] ath10k: Fix the parsing error in service available event

2020-10-28 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 10:01 AM Rakesh Pillai wrote: > > The wmi service available event has been > extended to contain extra 128 bit for new services > to be indicated by firmware. > > Currently the presence of any optional TLVs in > the wmi service available event leads to a parsing > erro

[PATCH v2] ath10k: Fix the parsing error in service available event

2020-10-28 Thread Rakesh Pillai
The wmi service available event has been extended to contain extra 128 bit for new services to be indicated by firmware. Currently the presence of any optional TLVs in the wmi service available event leads to a parsing error with the below error message: ath10k_snoc 1880.wifi: failed to parse