Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-05-20 Thread Brian Norris
Hi Alexey, On Fri, Apr 04, 2014 at 11:38:09AM +0400, Alexey Brodkin wrote: > Signed-off-by: Alexey Brodkin > > Reviewed-by: Ezequiel Garcia > > Cc: Ezequiel Garcia > Cc: Vineet Gupta > cc: Brian Norris > Cc: Grant Likely > Cc: David Woodhouse > Cc: Francois Bedard > Cc:

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-05-20 Thread Alexey Brodkin
Dear Brian, On Fri, 2014-04-18 at 02:12 +0400, Alexey Brodkin wrote: > Dear Brian, > > On Fri, 2014-04-11 at 12:07 -0300, ezequiel.gar...@free-electrons.com > wrote: > > On Apr 11, Alexey Brodkin wrote: > > > Hi Ezequiel, > > > > > > On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: > >

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-05-20 Thread Alexey Brodkin
Dear Brian, On Fri, 2014-04-18 at 02:12 +0400, Alexey Brodkin wrote: Dear Brian, On Fri, 2014-04-11 at 12:07 -0300, ezequiel.gar...@free-electrons.com wrote: On Apr 11, Alexey Brodkin wrote: Hi Ezequiel, On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: Hi Ezequiel,

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-05-20 Thread Brian Norris
Hi Alexey, On Fri, Apr 04, 2014 at 11:38:09AM +0400, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin abrod...@synopsys.com Reviewed-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Cc: Ezequiel Garcia ezequiel.gar...@free-electrons.com Cc: Vineet Gupta vgu...@synopsys.com cc:

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-17 Thread Alexey Brodkin
Dear Brian, On Fri, 2014-04-11 at 12:07 -0300, ezequiel.gar...@free-electrons.com wrote: > On Apr 11, Alexey Brodkin wrote: > > Hi Ezequiel, > > > > On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: > > > Hi Ezequiel, > > > > > > On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote:

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-17 Thread Alexey Brodkin
Dear Brian, On Fri, 2014-04-11 at 12:07 -0300, ezequiel.gar...@free-electrons.com wrote: On Apr 11, Alexey Brodkin wrote: Hi Ezequiel, On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: Hi Ezequiel, On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: On Apr 04,

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-11 Thread ezequiel.gar...@free-electrons.com
On Apr 11, Alexey Brodkin wrote: > Hi Ezequiel, > > On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: > > Hi Ezequiel, > > > > On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: > > > On Apr 04, Alexey Brodkin wrote: > > > > Signed-off-by: Alexey Brodkin > > > > > > > > > >

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-11 Thread Alexey Brodkin
Hi Ezequiel, On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: > Hi Ezequiel, > > On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: > > On Apr 04, Alexey Brodkin wrote: > > > Signed-off-by: Alexey Brodkin > > > > > > > Maybe it would be nice adding some driver description here,

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-11 Thread Alexey Brodkin
Hi Ezequiel, On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: Hi Ezequiel, On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: On Apr 04, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin abrod...@synopsys.com Maybe it would be nice adding some driver description

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-11 Thread ezequiel.gar...@free-electrons.com
On Apr 11, Alexey Brodkin wrote: Hi Ezequiel, On Mon, 2014-04-07 at 10:13 +0400, Alexey Brodkin wrote: Hi Ezequiel, On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: On Apr 04, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin abrod...@synopsys.com Maybe it

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-07 Thread Alexey Brodkin
Hi Ezequiel, On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: > On Apr 04, Alexey Brodkin wrote: > > Signed-off-by: Alexey Brodkin > > > > Maybe it would be nice adding some driver description here, so the commit > log actually says something useful about the commit. Well, I thought

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-07 Thread Alexey Brodkin
Hi Ezequiel, On Fri, 2014-04-04 at 11:09 -0300, Ezequiel Garcia wrote: On Apr 04, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin abrod...@synopsys.com Maybe it would be nice adding some driver description here, so the commit log actually says something useful about the commit.

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-04 Thread Ezequiel Garcia
On Apr 04, Alexey Brodkin wrote: > Signed-off-by: Alexey Brodkin > Maybe it would be nice adding some driver description here, so the commit log actually says something useful about the commit. [..] > Reviewed-by: Ezequiel Garcia > > +/** > + * axs_flag_wait_and_reset - Waits until requested

[PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-04 Thread Alexey Brodkin
Signed-off-by: Alexey Brodkin Reviewed-by: Ezequiel Garcia Cc: Ezequiel Garcia Cc: Vineet Gupta cc: Brian Norris Cc: Grant Likely Cc: David Woodhouse Cc: Francois Bedard Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- In this re-spin I addressed Ezequiel comments.

[PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-04 Thread Alexey Brodkin
Signed-off-by: Alexey Brodkin abrod...@synopsys.com Reviewed-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Cc: Ezequiel Garcia ezequiel.gar...@free-electrons.com Cc: Vineet Gupta vgu...@synopsys.com cc: Brian Norris computersforpe...@gmail.com Cc: Grant Likely grant.lik...@linaro.org

Re: [PATCH v2] axs_nand - add driver for NAND controller used on Synopsys AXS dev boards

2014-04-04 Thread Ezequiel Garcia
On Apr 04, Alexey Brodkin wrote: Signed-off-by: Alexey Brodkin abrod...@synopsys.com Maybe it would be nice adding some driver description here, so the commit log actually says something useful about the commit. [..] Reviewed-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com +/** +