Re: [PATCH v2] bitmap: remove explicit newline handling using scnprintf format string

2015-04-30 Thread Sudeep Holla
On 29/04/15 23:48, Andrew Morton wrote: On Tue, 28 Apr 2015 16:36:41 +0100 Sudeep Holla wrote: bitmap_print_to_pagebuf uses scnprintf to copy the cpumask/list to page buffer. It handles the newline and trailing null character explicitly. bitmap_print_to_pagebuf() is horrid :( That automag

Re: [PATCH v2] bitmap: remove explicit newline handling using scnprintf format string

2015-04-29 Thread Andrew Morton
On Tue, 28 Apr 2015 16:36:41 +0100 Sudeep Holla wrote: > bitmap_print_to_pagebuf uses scnprintf to copy the cpumask/list to page > buffer. It handles the newline and trailing null character explicitly. bitmap_print_to_pagebuf() is horrid :( That automagic "assume caller passed us an offset into

[PATCH v2] bitmap: remove explicit newline handling using scnprintf format string

2015-04-28 Thread Sudeep Holla
bitmap_print_to_pagebuf uses scnprintf to copy the cpumask/list to page buffer. It handles the newline and trailing null character explicitly. It's unnecessary and also partially duplicated as scnprintf already adds trailing null character. The newline can be passed through format string to scnpri