Re: [PATCH v2] block: recalculate segment count for multi-segment discards correctly

2021-03-23 Thread Jens Axboe
On 2/11/21 7:38 AM, David Jeffery wrote: > When a stacked block device inserts a request into another block device > using blk_insert_cloned_request, the request's nr_phys_segments field gets > recalculated by a call to blk_recalc_rq_segments in > blk_cloned_rq_check_limits. But

Re: [PATCH v2] block: recalculate segment count for multi-segment discards correctly

2021-02-14 Thread Ming Lei
On Thu, Feb 11, 2021 at 10:48 PM David Jeffery wrote: > > When a stacked block device inserts a request into another block device > using blk_insert_cloned_request, the request's nr_phys_segments field gets > recalculated by a call to blk_recalc_rq_segments in > blk_cloned_rq_check_limits. But

[PATCH v2] block: recalculate segment count for multi-segment discards correctly

2021-02-11 Thread David Jeffery
When a stacked block device inserts a request into another block device using blk_insert_cloned_request, the request's nr_phys_segments field gets recalculated by a call to blk_recalc_rq_segments in blk_cloned_rq_check_limits. But blk_recalc_rq_segments does not know how to handle multi-segment