Re: [PATCH v2] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-21 Thread Bui Quang Minh
On Tue, Jan 12, 2021 at 01:42:33PM +0700, Minh Bùi Quang wrote: > On Mon, Jan 11, 2021 at 9:31 PM Bui Quang Minh > wrote: > > > > On Mon, Jan 11, 2021 at 01:00:31PM +0100, Oliver Neukum wrote: > > > Am Montag, den 11.01.2021, 10:49 + schrieb Bui Quang Minh: > > > > In mcba_usb_read_bulk_callb

Re: [PATCH v2] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-11 Thread Minh Bùi Quang
On Mon, Jan 11, 2021 at 9:31 PM Bui Quang Minh wrote: > > On Mon, Jan 11, 2021 at 01:00:31PM +0100, Oliver Neukum wrote: > > Am Montag, den 11.01.2021, 10:49 + schrieb Bui Quang Minh: > > > In mcba_usb_read_bulk_callback(), when we don't resubmit or fails to > > > resubmit the urb, we need to

Re: [PATCH v2] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-11 Thread Bui Quang Minh
On Mon, Jan 11, 2021 at 01:00:31PM +0100, Oliver Neukum wrote: > Am Montag, den 11.01.2021, 10:49 + schrieb Bui Quang Minh: > > In mcba_usb_read_bulk_callback(), when we don't resubmit or fails to > > resubmit the urb, we need to deallocate the transfer buffer that is > > allocated in mcba_usb_

Re: [PATCH v2] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-11 Thread Oliver Neukum
Am Montag, den 11.01.2021, 10:49 + schrieb Bui Quang Minh: > In mcba_usb_read_bulk_callback(), when we don't resubmit or fails to > resubmit the urb, we need to deallocate the transfer buffer that is > allocated in mcba_usb_start(). > > Reported-by: syzbot+57281c762a3922e14...@syzkaller.appspo

[PATCH v2] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-11 Thread Bui Quang Minh
In mcba_usb_read_bulk_callback(), when we don't resubmit or fails to resubmit the urb, we need to deallocate the transfer buffer that is allocated in mcba_usb_start(). Reported-by: syzbot+57281c762a3922e14...@syzkaller.appspotmail.com Signed-off-by: Bui Quang Minh --- v1: add memory leak fix when