Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Marc Kleine-Budde
On Thu, Jan 21, 2021 at 05:33:40PM +0800, Su wrote: > The sizeof(u32) is hardcoded. IMO it's better to use the config value in > regmap. I got why you want to change this. Please update the patch description, comment on the increase of the object size and address the other issues I pointed out. I

Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Su
The sizeof(u32) is hardcoded. IMO it's better to use the config value in regmap. Thanks 在 2021/1/21 下午5:21, Marc Kleine-Budde 写道: On Thu, Jan 21, 2021 at 05:10:05PM +0800, Su Yanjun wrote: Please describe why you change this. No functional effect. Not quite: scripts/bloat-o-meter shows:

Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Marc Kleine-Budde
On Thu, Jan 21, 2021 at 05:10:05PM +0800, Su Yanjun wrote: Please describe why you change this. > No functional effect. Not quite: scripts/bloat-o-meter shows: add/remove: 0/0 grow/shrink: 3/0 up/down: 104/0 (104) Function old new delta mcp251xfd_handl

[PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Su Yanjun
No functional effect. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c index f07e8b737d