Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Sun, 2020-11-29 at 05:29 +0200, Jarkko Sakkinen wrote: > On Thu, Nov 26, 2020 at 03:19:24AM -0300, Ezequiel Garcia wrote: > > On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote: > > > On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote: > > > > Hi Jarkko, > > > > > > > > Thanks for

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Thu, Nov 26, 2020 at 03:19:24AM -0300, Ezequiel Garcia wrote: > On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote: > > On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote: > > > Hi Jarkko, > > > > > > Thanks for your review. > > > > > > On Tue, 2020-11-24 at 00:06 +0200, Jarkko

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Thu, 26 Nov 2020, Ezequiel Garcia wrote: On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote: On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote: > Hi Jarkko, Thanks for your review. On Tue, 2020-11-24 at > 00:06 +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 20, 2020 at

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote: > On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote: > > Hi Jarkko, > > > > Thanks for your review. > > > > On Tue, 2020-11-24 at 00:06 +0200, Jarkko Sakkinen wrote: > > > On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote: > Hi Jarkko, > > Thanks for your review. > > On Tue, 2020-11-24 at 00:06 +0200, Jarkko Sakkinen wrote: > > On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu wrote: > > > From: "dlau...@chromium.org" > > > > > > Add TPM 2.0

Re: [PATCH v2] char: tpm: add i2c driver for cr50

Hi Jarkko, Thanks for your review. On Tue, 2020-11-24 at 00:06 +0200, Jarkko Sakkinen wrote: > On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu wrote: > > From: "dlau...@chromium.org" > > > > Add TPM 2.0 compatible I2C interface for chips with cr50 firmware. > > > > The firmware running

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Tue, 24 Nov 2020, Jarkko Sakkinen wrote: On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu wrote: From: "dlau...@chromium.org" Add TPM 2.0 compatible I2C interface for chips with cr50 firmware. The firmware running on the currently supported H1 MCU requires a special driver to

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu wrote: > From: "dlau...@chromium.org" > > Add TPM 2.0 compatible I2C interface for chips with cr50 firmware. > > The firmware running on the currently supported H1 MCU requires a > special driver to handle its specific protocol, and this

Re: [PATCH v2] char: tpm: add i2c driver for cr50

On Fri, 20 Nov 2020, Helen Koike wrote: Hello Adrian, I just spotted small things (nothing major), please see below. Hi Helen, I've addressed all the points you raised and left some minor comments below, but I will wait a little longer before posting v3 so others will also have a chance

Re: [PATCH v2] char: tpm: add i2c driver for cr50

Hello Adrian, I just spotted small things (nothing major), please see below. On 11/20/20 2:23 PM, Adrian Ratiu wrote: > From: "dlau...@chromium.org" > > Add TPM 2.0 compatible I2C interface for chips with cr50 firmware. > > The firmware running on the currently supported H1 MCU requires a >

[PATCH v2] char: tpm: add i2c driver for cr50

From: "dlau...@chromium.org" Add TPM 2.0 compatible I2C interface for chips with cr50 firmware. The firmware running on the currently supported H1 MCU requires a special driver to handle its specific protocol, and this makes it unsuitable to use tpm_tis_core_* and instead it must implement the