Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset

2016-04-30 Thread Eli Billauer
Fine with me. Thanks. Acked-by: Eli Billauer On 30/04/16 19:13, Sudip Mukherjee wrote: If devm_add_action() fails we are explicitly calling dma_unmap_single(), pci_unmap_single() and kfree(). Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that t

[PATCH v2] char: xillybus: use devm_add_action_or_reset

2016-04-30 Thread Sudip Mukherjee
If devm_add_action() fails we are explicitly calling dma_unmap_single(), pci_unmap_single() and kfree(). Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that the cleanup function has been already called by the helper if there was any error. At that sa