Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

2012-09-05 Thread Joe Perches
On Thu, 2012-09-06 at 02:16 +0200, Philippe De Muyter wrote: > On Wed, Sep 5, 2012 at 7:07 PM, Joe Perches wrote: > > On Wed, 2012-09-05 at 13:21 +0200, Philippe De Muyter wrote: > >> > v2: Make $match_balanced_parentheses work in perl 5.8 > >> > >> Has this been applied ? > >> > >> v3.3 version

Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

2012-09-05 Thread Philippe De Muyter
On Wed, Sep 5, 2012 at 7:07 PM, Joe Perches wrote: > On Wed, 2012-09-05 at 13:21 +0200, Philippe De Muyter wrote: >> > v2: Make $match_balanced_parentheses work in perl 5.8 >> >> Has this been applied ? >> >> v3.3 version of checkpatch.pl works for me, but v3.4, v3.5 & v3.6rc2 say: >> Nested quan

Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

2012-09-05 Thread Joe Perches
On Wed, 2012-09-05 at 13:21 +0200, Philippe De Muyter wrote: > On 5/27/11, Joe Perches wrote: > > A common issue with min() or max() is using a cast on > > one or both of the arguments when using min_t/max_t could > > be better. > > > > Add cast detection to uses of min/max and suggest an > > appr

Re: [PATCH v2] checkpatch: Suggest using min_t or max_t

2012-09-05 Thread Philippe De Muyter
On 5/27/11, Joe Perches wrote: > A common issue with min() or max() is using a cast on > one or both of the arguments when using min_t/max_t could > be better. > > Add cast detection to uses of min/max and suggest an > appropriate use of min_t or max_t instead. > > Caveat: This only works for min