Re: [PATCH v2] checkpatch.pl: New instances of ENOSYS are errors

2014-08-25 Thread Andy Lutomirski
On Aug 25, 2014 3:29 AM, "Pavel Machek" wrote: > > On Fri 2014-08-22 09:26:31, Andy Lutomirski wrote: > > ENOSYS means that a nonexistent system call was called. We have a > > bad habit of using it for things like invalid operations on > > otherwise valid syscalls. We should avoid this in new co

Re: [PATCH v2] checkpatch.pl: New instances of ENOSYS are errors

2014-08-25 Thread Pavel Machek
On Fri 2014-08-22 09:26:31, Andy Lutomirski wrote: > ENOSYS means that a nonexistent system call was called. We have a > bad habit of using it for things like invalid operations on > otherwise valid syscalls. We should avoid this in new code. Is it good idea? I mean, doing EINVAL for subcalls is

Re: [PATCH v2] checkpatch.pl: New instances of ENOSYS are errors

2014-08-22 Thread Joe Perches
On Fri, 2014-08-22 at 09:26 -0700, Andy Lutomirski wrote: > ENOSYS means that a nonexistent system call was called. We have a > bad habit of using it for things like invalid operations on > otherwise valid syscalls. We should avoid this in new code. [] > diff --git a/scripts/checkpatch.pl b/scrip

[PATCH v2] checkpatch.pl: New instances of ENOSYS are errors

2014-08-22 Thread Andy Lutomirski
ENOSYS means that a nonexistent system call was called. We have a bad habit of using it for things like invalid operations on otherwise valid syscalls. We should avoid this in new code. Signed-off-by: Andy Lutomirski --- Pervasive incorrect usage of ENOSYS came up at the kernel summit ABI revi