Re: Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-30 Thread Stephen Boyd
Quoting wang.y...@zte.com.cn (2018-10-29 23:13:24) > > Quoting Yi Wang (2018-10-29 01:31:47) > > > 'onecell' is malloced in clk_boston_setup(), but is not freed > > > before leaving from the error handling cases. > > > > How did you find this? Visual inspection? Some coccinelle script? > > Smatch

Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-29 Thread Stephen Boyd
Quoting Yi Wang (2018-10-29 01:31:47) > 'onecell' is malloced in clk_boston_setup(), but is not freed > before leaving from the error handling cases. How did you find this? Visual inspection? Some coccinelle script? > > Signed-off-by: Yi Wang > --- > v2: fix syntax issue in comment, thanks to

[PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-29 Thread Yi Wang
'onecell' is malloced in clk_boston_setup(), but is not freed before leaving from the error handling cases. Signed-off-by: Yi Wang --- v2: fix syntax issue in comment, thanks to Sergei. drivers/clk/imgtec/clk-boston.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --gi