Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-10 Thread shilpa
On 09/01/2014 02:42 PM, David Laight wrote: >> Yes unlikely() should cover the whole if statement... > > Actually it probably shouldn't. > You need to look at the generated code with each different set of 'unlikely()' > to see how gcc processes them. > In this case, if 'rebooting' is false you

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-10 Thread shilpa
On 09/01/2014 02:42 PM, David Laight wrote: Yes unlikely() should cover the whole if statement... Actually it probably shouldn't. You need to look at the generated code with each different set of 'unlikely()' to see how gcc processes them. In this case, if 'rebooting' is false you want to

RE: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-01 Thread David Laight
From: Shilpa Bhat > Hi Viresh, > On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: > > On 28 August 2014 19:36, Shilpasri G Bhat > > wrote: > > > > > > Changes v1->v2: > > > Invoke .target() driver callback to set the cpus to nominal frequency > > > in reboot notifier, instead of calling

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-01 Thread Shilpa Bhat
This patch ensures the cpus to kexec/reboot at nominal frequency. Nominal frequency is the highest cpu frequency on PowerPC at which the cores can run without getting throttled. If the host kernel had set the cpus to a low pstate and then it kexecs/reboots to a cpufreq disabled kernel it would

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-01 Thread Shilpa Bhat
This patch ensures the cpus to kexec/reboot at nominal frequency. Nominal frequency is the highest cpu frequency on PowerPC at which the cores can run without getting throttled. If the host kernel had set the cpus to a low pstate and then it kexecs/reboots to a cpufreq disabled kernel it would

RE: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-09-01 Thread David Laight
From: Shilpa Bhat Hi Viresh, On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: On 28 August 2014 19:36, Shilpasri G Bhat shilpa.b...@linux.vnet.ibm.com wrote: Changes v1-v2: Invoke .target() driver callback to set the cpus to nominal frequency in reboot notifier, instead of

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-31 Thread Viresh Kumar
On 1 September 2014 10:48, Shilpa Bhat wrote: > Hi Viresh, > On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: >> On 28 August 2014 19:36, Shilpasri G Bhat >> wrote: >> > >> > Changes v1->v2: >> > Invoke .target() driver callback to set the cpus to nominal frequency >> > in reboot notifier,

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-31 Thread Shilpa Bhat
Hi Viresh, On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: > On 28 August 2014 19:36, Shilpasri G Bhat > wrote: > > > > Changes v1->v2: > > Invoke .target() driver callback to set the cpus to nominal frequency > > in reboot notifier, instead of calling cpufreq_suspend() as suggested > > by

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-31 Thread Shilpa Bhat
Hi Viresh, On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: On 28 August 2014 19:36, Shilpasri G Bhat shilpa.b...@linux.vnet.ibm.com wrote: Changes v1-v2: Invoke .target() driver callback to set the cpus to nominal frequency in reboot notifier, instead of calling cpufreq_suspend()

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-31 Thread Viresh Kumar
On 1 September 2014 10:48, Shilpa Bhat shilpa.b...@linux.vnet.ibm.com wrote: Hi Viresh, On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: On 28 August 2014 19:36, Shilpasri G Bhat shilpa.b...@linux.vnet.ibm.com wrote: Changes v1-v2: Invoke .target() driver callback to set the cpus

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-28 Thread Viresh Kumar
On 28 August 2014 19:36, Shilpasri G Bhat wrote: > This patch ensures the cpus to kexec/reboot at nominal frequency. > Nominal frequency is the highest cpu frequency on PowerPC at > which the cores can run without getting throttled. > > If the host kernel had set the cpus to a low pstate and then

[PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-28 Thread Shilpasri G Bhat
This patch ensures the cpus to kexec/reboot at nominal frequency. Nominal frequency is the highest cpu frequency on PowerPC at which the cores can run without getting throttled. If the host kernel had set the cpus to a low pstate and then it kexecs/reboots to a cpufreq disabled kernel it would

[PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-28 Thread Shilpasri G Bhat
This patch ensures the cpus to kexec/reboot at nominal frequency. Nominal frequency is the highest cpu frequency on PowerPC at which the cores can run without getting throttled. If the host kernel had set the cpus to a low pstate and then it kexecs/reboots to a cpufreq disabled kernel it would

Re: [PATCH v2] cpufreq: powernv: Set the cpus to nominal frequency during reboot/kexec

2014-08-28 Thread Viresh Kumar
On 28 August 2014 19:36, Shilpasri G Bhat shilpa.b...@linux.vnet.ibm.com wrote: This patch ensures the cpus to kexec/reboot at nominal frequency. Nominal frequency is the highest cpu frequency on PowerPC at which the cores can run without getting throttled. If the host kernel had set the cpus